Notebook API: Support Language Providers for Notebook Output Cells

[pgfearo]

Please reinstate support for SemanticTokenProvider and DocumentLinkProvider for JSON Notebook output cells.

In May 2022 these providers worked in an XPath Notebook as expected on a JSON output cell when the output cell was rendering the result of an executed XPath expression that included XML nodes - see screenshot from May 2022:

Each XPath node in the result was represented as an XPath location with special syntax-highlighting. The highlighted XPath location functioned as a document-link. Clicking on this would select the corresponding node in the XML document open in VS Code.

Here's the code used to register the providers:

vscode.languages.registerDocumentSemanticTokensProvider({ language: 'json', notebookType: 'xbook' }, new XpathResultTokenProvider(), XpathResultTokenProvider.getLegend()),
vscode.languages.registerDocumentLinkProvider({ language: 'json', notebookType: 'xbook' }, new LinkProvider()),

A VS Code update some time after May 2022 caused language providers for JSON output cells to no longer work. There is now no special syntax-highlighting and a ctrl-click on the XPath location has no effect.

Please consider reinstating support for this feature in VS Code. For info, this is issue #10 as submitted on the XPath Notebook repository.

I'm submitting this as a feature request rather than a bug report because it's possible that the (output cell) language provider feature that this Notebook extension exploits was not intentional.

[vscodenpa]

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

[vscodenpa]

🙂 This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

[pgfearo]

Any chance of some response that isn't from a bot? Even if it's a "won't do" with some rationale?

[psuzzi]

As of April 2023, this is still an open issue.