Skip to content

Commit 1a29338

Browse files
authored
Tactical change for refreshing PRs tree (#7357)
* Tactical change for refreshing PRs tree * Change poll interval, add event * small diff
1 parent e876b13 commit 1a29338

File tree

4 files changed

+11
-11
lines changed

4 files changed

+11
-11
lines changed

src/github/copilotPrWatcher.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ export class CopilotPRWatcher extends Disposable {
117117
if (shouldContinue) {
118118
this._timeout = setTimeout(() => {
119119
this._pollForChanges();
120-
}, 60 * 1000); // Poll every minute
120+
}, 3 * 60 * 1000); // Poll every 3 minute
121121
}
122122
}
123123

src/github/folderRepositoryManager.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1165,6 +1165,12 @@ export class FolderRepositoryManager extends Disposable {
11651165
Logger.debug(`Fetch pull request category ${categoryQuery} - enter`, this.id);
11661166
const { octokit, query, schema } = await githubRepository.ensure();
11671167

1168+
/* __GDPR__
1169+
"pr.search.category" : {
1170+
}
1171+
*/
1172+
this.telemetry.sendTelemetryEvent('pr.search.category');
1173+
11681174
const user = (await githubRepository.getAuthenticatedUser()).login;
11691175
// Search api will not try to resolve repo that redirects, so get full name first
11701176
repo = await githubRepository.getMetadata();
@@ -1202,7 +1208,7 @@ export class FolderRepositoryManager extends Disposable {
12021208
// Pull requests fetched with a query can be from any repo.
12031209
// We need to use the correct GitHubRepository for this PR.
12041210
return response.repo.createOrUpdatePullRequestModel(
1205-
await parseGraphQLPullRequest(response.data.repository.pullRequest, response.repo),
1211+
await parseGraphQLPullRequest(response.data.repository.pullRequest, response.repo)
12061212
);
12071213
})))
12081214
.filter(item => item !== null) as PullRequestModel[];

src/github/githubRepository.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1511,7 +1511,7 @@ export class GitHubRepository extends Disposable {
15111511
}
15121512
const oldTimeline = issueModel.timelineEvents;
15131513
issueModel.timelineEvents = allEvents;
1514-
if (!oldLastEvent || (allEvents.length !== oldTimeline.length)) {
1514+
if (oldTimeline.length > 0 && allEvents.length !== oldTimeline.length) {
15151515
this._onDidChangePullRequests.fire();
15161516
}
15171517
}
@@ -1632,7 +1632,7 @@ export class GitHubRepository extends Disposable {
16321632
Logger.debug(`Fetch timeline events of PR #${pullRequestModel.number} - done`, PullRequestModel.ID);
16331633
const oldEvents = pullRequestModel.timelineEvents;
16341634
pullRequestModel.timelineEvents = events;
1635-
if (oldEvents.length !== events.length) {
1635+
if ((oldEvents.length > 0) && oldEvents.length !== events.length) {
16361636
this._onDidChangePullRequests.fire();
16371637
}
16381638
return events;

src/view/prsTreeModel.ts

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -50,17 +50,11 @@ export class PrsTreeModel extends Disposable {
5050
}
5151

5252
this._repoEvents.get(manager)!.push(manager.onDidChangeActivePullRequest(() => {
53-
this.clearRepo(manager);
53+
this._onDidChangeData.fire(manager);
5454
if (this._activePRDisposables.has(manager)) {
5555
disposeAll(this._activePRDisposables.get(manager)!);
5656
this._activePRDisposables.delete(manager);
5757
}
58-
if (manager.activePullRequest) {
59-
this._activePRDisposables.set(manager, [
60-
manager.activePullRequest.onDidChangeComments(() => {
61-
this.clearRepo(manager);
62-
})]);
63-
}
6458
}));
6559
this._repoEvents.get(manager)!.push(manager.onDidChangeAnyPullRequests(() => {
6660
this._onDidChangeData.fire(manager);

0 commit comments

Comments
 (0)