fix: screenshot type inferred from path file extension #2951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@microsoft-github-policy-service agree |
Contributor
|
Please start with filing an issue, changes like this would require us to make it across all the language ports we maintain. |
Contributor
Author
OK. An issue is created in #2955 |
mxschmitt
approved these changes
Aug 19, 2025
Contributor
mxschmitt
left a comment
mxschmitt
left a comment
There was a problem hiding this comment.
Looks great! Any chance for a test? Ideally in tests/async/test_screenshot.py.
Contributor
Author
Tests were added. Please have a check. |
mxschmitt
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
screenshotmethods for both element and page do not really infer file type frompathfile extension iftypeis not provided. I tried some name like 'xxx.jpeg' withouttypein arguments, the generated file format was actually png.This pull request is trying to fix this.
Fixes #2955