You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry-picked a part of features from #167: now Communicator::setup() is unneeded. Communicator::sendMemory() conducts the task inline, and Communicator::recvMemory() and Communicator::connect() conducts the task asynchronously without explicit setup.
Try to understand this PR correctly. It only addresses the connection phase and does not resolve the issue of supporting on-side registered memory. In the send/recv case, both ranks still need to send their registered memory information to the peer, even though the receiving side does not require the peer's registered memory right?
Try to understand this PR correctly. It only addresses the connection phase and does not resolve the issue of supporting on-side registered memory. In the send/recv case, both ranks still need to send their registered memory information to the peer, even though the receiving side does not require the peer's registered memory right?
This is not what this PR addresses. What you are talking about is the channel's requirement. This PR is only about simplifying the initialization phase.
* In cases when the same `tag` is used for receiving data from the same
remote rank, #514 changed the behavior of `Communicator::connect` and
`Communicator::recvMemory` to receive data in the order of
`std::shared_future::get()` is called, instead of the original behvaior
that receive data in the order of the method calls. Since the original
behavior is more intuitive, we get that back. Now when `get()` is called
on a future, the async function will first call `wait()` on the latest
previously returned future. In a recursive manner, this will call
`wait()` on all previous futures that are not yet ready.
* Removed all deprecated API calls and replaced into the new ones.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked a part of features from #167: now
Communicator::setup()is unneeded.Communicator::sendMemory()conducts the task inline, andCommunicator::recvMemory()andCommunicator::connect()conducts the task asynchronously without explicit setup.