Skip to content

docs: 📝 🚀✨ Update README: Added token expiration ⏳ and security tips 🔒! Plus, fresh new images 🌟📸 for token setup—making things clearer and prettier! 🛠️💼 #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

indcoder
Copy link
Contributor

@indcoder indcoder commented Apr 2, 2025

Closes #129

…🔒! Plus, fresh new images 🌟📸 for token setup—making things clearer and prettier! 🛠️💼

Closes microsoft#129
@Copilot Copilot AI review requested due to automatic review settings April 2, 2025 08:03
Copy link

github-actions bot commented Apr 2, 2025

👋 Thanks for contributing @indcoder! We will review the pull request and get back to you soon.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the README documentation to provide clearer instructions on creating a token with expiration and adds new security tips along with updated images.

  • Introduces an expiration policy for tokens with visual aids.
  • Updates headers to reflect keyless authentication and environment variable access.

Comment on lines 38 to 39
Instead of a token with no expiration date, we recommend creating one for limited days eg: 60 days [if done at the start of April 2025 conveniently coincides with the duration of [AI Skills fest](https://techcommunity.microsoft.com/blog/microsoftlearnblog/register-now-for-the-microsoft-ai-skills-fest/4292261?wt.mc_id=DT-MVP-500304

Copy link
Preview

Copilot AI Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There appears to be a markdown formatting issue with the link: an extra '[' is leading to an unclosed link syntax. Consider correcting the bracket usage to ensure the link renders properly.

Suggested change
Instead of a token with no expiration date, we recommend creating one for limited days eg: 60 days [if done at the start of April 2025 conveniently coincides with the duration of [AI Skills fest](https://techcommunity.microsoft.com/blog/microsoftlearnblog/register-now-for-the-microsoft-ai-skills-fest/4292261?wt.mc_id=DT-MVP-500304
Instead of a token with no expiration date, we recommend creating one for limited days eg: 60 days if done at the start of April 2025 conveniently coincides with the duration of [AI Skills fest](https://techcommunity.microsoft.com/blog/microsoftlearnblog/register-now-for-the-microsoft-ai-skills-fest/4292261?wt.mc_id=DT-MVP-500304).

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove your MVP Tracker.

Comment on lines 42 to 44
Also, as an additional security measure, we can restrict the token to only be used for the `ai-agents-for-beginners` repository [[Least Privilege Principle](https://en.wikipedia.
org/wiki/Principle_of_least_privilege)].

Copy link
Preview

Copilot AI Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The markdown link for 'Least Privilege Principle' is split across two lines, which may break the link rendering. Moving the entire URL to a single line should resolve this issue.

Suggested change
Also, as an additional security measure, we can restrict the token to only be used for the `ai-agents-for-beginners` repository [[Least Privilege Principle](https://en.wikipedia.
org/wiki/Principle_of_least_privilege)].
Also, as an additional security measure, we can restrict the token to only be used for the `ai-agents-for-beginners` repository [[Least Privilege Principle](https://en.wikipedia.org/wiki/Principle_of_least_privilege)].

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

@indcoder
Copy link
Contributor Author

indcoder commented Apr 7, 2025

I would request to retain it.. Infact thanks to your comment I noticed there was an error in it because I rushed to put it in. I added that so that Microsoft can track these micro nudges from MS Learn Beginner Series to Program Initiatives like AI Skills Fest, Season of Agents etc and I have reminder for a follow up PR on 31st May 2025 to remove it. This PR is important to inculcate Zero Trust and LPA with college students for which we are beginning tomorrow https://x.com/augvcor/status/1909194849183543461

![Expiry date of token](./images/token_with_expiry_date.png)

Also, as an additional security measure, we can restrict the token to only be used for the `ai-agents-for-beginners` repository [[Least Privilege Principle](https://en.wikipedia.org/wiki/Principle_of_least_privilege)].
![Select GitHub repository](./images/token_select_repositories.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can we include more visually appealing images instead of annotations draw by hand/mouse? the "Generate Token" image looks good.

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree here - would be helpful with some quick improvements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PAT : FGA missing crucial access options
4 participants