Skip to content

Commit 342eb5b

Browse files
authored
PyPi publish makefile rules fixup (#640)
Prior Makefile rule consolidation tried to group dependencies for the pattern rule into separate lines for readability, but apparently this isn't allowed. This minor changes separates those out into a variable we can reference instead. Tested on a clean build tree locally.
1 parent e2a0e10 commit 342eb5b

File tree

5 files changed

+15
-14
lines changed

5 files changed

+15
-14
lines changed

.bumpversion.cfg

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
[bumpversion]
2-
current_version = 0.3.1
2+
current_version = 0.3.2
33
commit = True
44
tag = True
55

Makefile

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -346,27 +346,28 @@ dist-test-clean: dist-test-env-clean
346346
publish: publish-pypi
347347

348348
.PHONY:
349-
publish-pypi-deps: build/publish-pypi-deps.build-stamp
349+
publish-pypi-deps: build/publish-pypi-deps.${CONDA_ENV_NAME}.build-stamp
350350

351351
build/publish-pypi-deps.${CONDA_ENV_NAME}.build-stamp: build/conda-env.${CONDA_ENV_NAME}.build-stamp
352352
conda run -n ${CONDA_ENV_NAME} pip install -U twine
353353
touch $@
354354

355-
build/publish.%.py.build-stamp: build/publish-pypi-deps.${CONDA_ENV_NAME}.build-stamp
356-
build/publish.%.py.build-stamp: build/pytest.${CONDA_ENV_NAME}.build-stamp
357-
build/publish.%.py.build-stamp: build/dist-test.$(PYTHON_VERSION).build-stamp
358-
build/publish.%.py.build-stamp: build/check-doc.build-stamp
359-
build/publish.%.py.build-stamp: build/linklint-doc.build-stamp
360-
build/publish.%.py.build-stamp:
355+
PUBLISH_DEPS := build/publish-pypi-deps.${CONDA_ENV_NAME}.build-stamp
356+
PUBLISH_DEPS += build/pytest.${CONDA_ENV_NAME}.build-stamp
357+
PUBLISH_DEPS += build/dist-test.$(PYTHON_VERSION).build-stamp
358+
PUBLISH_DEPS += build/check-doc.build-stamp
359+
PUBLISH_DEPS += build/linklint-doc.build-stamp
360+
361+
build/publish.${CONDA_ENV_NAME}.%.py.build-stamp: $(PUBLISH_DEPS)
361362
rm -f mlos_*/dist/*.tar.gz
362363
ls mlos_*/dist/*.tar | xargs -I% gzip -k %
363-
repo_name=`echo "$@" | sed -e 's|build/publish\.||' -e 's|\.py\.build-stamp||'` \
364+
repo_name=`echo "$@" | sed -r -e 's|build/publish\.[^.]+\.||' -e 's|\.py\.build-stamp||'` \
364365
&& conda run -n ${CONDA_ENV_NAME} python3 -m twine upload --repository $$repo_name \
365366
mlos_*/dist/mlos*-*.tar.gz mlos_*/dist/mlos*-*.whl
366367
touch $@
367368

368-
publish-pypi: build/publish.pypi.py.build-stamp
369-
publish-test-pypi: build/publish.testpypi.py.build-stamp
369+
publish-pypi: build/publish.${CONDA_ENV_NAME}.pypi.py.build-stamp
370+
publish-test-pypi: build/publish.${CONDA_ENV_NAME}.testpypi.py.build-stamp
370371

371372
build/doc-prereqs.${CONDA_ENV_NAME}.build-stamp: build/conda-env.${CONDA_ENV_NAME}.build-stamp
372373
build/doc-prereqs.${CONDA_ENV_NAME}.build-stamp: doc/requirements.txt

doc/source/conf.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
author = 'GSL'
3737

3838
# The full version, including alpha/beta/rc tags
39-
release = '0.3.1'
39+
release = '0.3.2'
4040

4141
try:
4242
from setuptools_scm import get_version

mlos_bench/_version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,4 @@
77
"""
88

99
# NOTE: This should be managed by bumpversion.
10-
_VERSION = '0.3.1'
10+
_VERSION = '0.3.2'

mlos_core/_version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,4 @@
77
"""
88

99
# NOTE: This should be managed by bumpversion.
10-
_VERSION = '0.3.1'
10+
_VERSION = '0.3.2'

0 commit comments

Comments
 (0)