Skip to content
This repository was archived by the owner on Aug 22, 2024. It is now read-only.

Commit eb521fb

Browse files
committed
Addressing PR revie comments; some README corrections and minor code corrections
1 parent cf4e844 commit eb521fb

File tree

5 files changed

+11
-11
lines changed

5 files changed

+11
-11
lines changed

examples/depth_eval_tools/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
Depth Evaluation Example Tools for Azure Kinect DK.
66

7-
These tools enable developers to collect depth and color images from a Azure Kinect device (`collect`), convert mkv files to images (`mkv2images`), evaluate the depth bias (`depth_eval`), and evaluate the transformation re-projection error between sensors (`transformation_eval`).
7+
These tools enable developers to collect depth and color images from a Azure Kinect device using the `collect` and `mkv2images` tools, or from any camera as long as the data can be converted to `mkv` format. Developers can then evaluate the depth bias and evaluate the transformation re-projection error between sensors using the `depth_eval` and `transformation_eval` tools.
88

99
---
1010
## Setup
@@ -49,8 +49,8 @@
4949

5050
```
5151
./collect -h or -help or -? print the help message
52-
./collect -mode=<depth mode> -nv=<num of views> -nc=<num of captures per view> -fps=<frame rate enum>
53-
-cal=<dump cal file> -xy=<dump xytable> -d=<capture depth> -i=<capture ir> -c=<capture color>
52+
./collect -mode=<depth mode> -res=<color resolution> -nv=<num of views> -nc=<num of captures per view>
53+
-fps=<frame rate enum> -cal=<dump cal file> -xy=<dump xytable> -d=<capture depth> -i=<capture ir> -c=<capture color>
5454
-out=<output directory>
5555
-gg=<gray_gamma used to convert ir data to 8bit gray image. default=0.5>
5656
-gm=<gray_max used to convert ir data to 8bit gray image. default=4000.0>

examples/depth_eval_tools/collect/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@
1111
## Usage
1212
```
1313
./collect -h or -help or -? print the help message
14-
./collect -mode=<depth mode> -nv=<num of views> -nc=<num of captures per view> -fps=<frame rate enum>
15-
-cal=<dump cal file> -xy=<dump xytable> -d=<capture depth> -i=<capture ir> -c=<capture color>
14+
./collect -mode=<depth mode> -res=<color resolution> -nv=<num of views> -nc=<num of captures per view>
15+
-fps=<frame rate enum> -cal=<dump cal file> -xy=<dump xytable> -d=<capture depth> -i=<capture ir> -c=<capture color>
1616
-out=<output directory>
1717
-gg=<gray_gamma used to convert ir data to 8bit gray image. default=0.5>
1818
-gm=<gray_max used to convert ir data to 8bit gray image. default=4000.0>

examples/depth_eval_tools/collect/collect.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ void help()
2727
<< "\nCollect depth and color images from K4A.\n"
2828
"Usage:\n"
2929
"./collect -h or -help or -? print this help message\n"
30-
"./collect -mode=<depth mode> -nv=<num of views> -nc=<num of captures per view> -fps=<frame rate enum>"
31-
" -cal=<dump cal file> -xy=<dump xytable> -d=<capture depth> -i=<capture ir> -c=<capture color>"
30+
"./collect -mode=<depth mode> -res=<color resolution> -nv=<num of views> -nc=<num of captures per view> "
31+
" -fps=<frame rate enum> -cal=<dump cal file> -xy=<dump xytable> -d=<capture depth> -i=<capture ir> -c=<capture color>"
3232
" -out=<output directory>\n"
3333
" -gg=<gray_gamma used to convert ir data to 8bit gray image. default=0.5>\n"
3434
" -gm=<gray_max used to convert ir data to 8bit gray image. default=4000.0>\n"

examples/depth_eval_tools/transformation_eval/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@
88

99
This tool utilizes two mkv files.
1010

11-
The 1st mkv file is PASSIVE_IR recorded using: ```k4arecorder.exe - c 3072p - d PASSIVE_IR - l 3 board1.mkv```
11+
The 1st mkv file is PASSIVE_IR recorded using: ```k4arecorder.exe -c 3072p -d PASSIVE_IR -l 3 board1.mkv```
1212

13-
The 2nd mkv file is WFOV_2X2BINNED recorded using: ```k4arecorder.exe - c 3072p - d WFOV_2X2BINNED - l 3 board2.mkv```
13+
The 2nd mkv file is WFOV_2X2BINNED recorded using: ```k4arecorder.exe -c 3072p -d WFOV_2X2BINNED -l 3 board2.mkv```
1414

1515
This version supports WFOV_2X2BINNED but can be easily generalized.
1616

examples/depth_eval_tools/transformation_eval/transformation_eval.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ void help()
2323
std::cout << "\nTransformation Evaluation Tool for K4A.\n";
2424
std::cout << "\nit uses 2 mkv files:\n";
2525
std::cout
26-
<< "\t 1st is PASSIVE_IR recorded using: \n\t\t k4arecorder.exe - c 3072p - d PASSIVE_IR - l 3 board1.mkv\n";
27-
std::cout << "\t 2nd is WFOV_2X2BINNED recorded using: \n\t\t k4arecorder.exe - c 3072p - d WFOV_2X2BINNED - l 3 "
26+
<< "\t 1st is PASSIVE_IR recorded using: \n\t\t k4arecorder.exe -c 3072p -d PASSIVE_IR -l 3 board1.mkv\n";
27+
std::cout << "\t 2nd is WFOV_2X2BINNED recorded using: \n\t\t k4arecorder.exe -c 3072p -d WFOV_2X2BINNED -l 3 "
2828
"board2.mkv\n";
2929
std::cout << "\t This version supports WFOV_2X2BINNED but can be easily generalized\n";
3030
std::cout << "Usage:\n"

0 commit comments

Comments
 (0)