Skip to content

Conversation

@sdelamo
Copy link
Contributor

@sdelamo sdelamo commented Feb 1, 2024

it is slightly faster to use Jackson databind

CleanShot 2024-02-01 at 10 42 25@2x

it is slightly faster to use jackson databind
@sdelamo sdelamo added the type: enhancement New feature or request label Feb 1, 2024
@sdelamo sdelamo requested a review from timyates February 1, 2024 10:18
@graemerocher
Copy link
Contributor

personally don't think we should make this change. Instead we should profile startup of serde and see how it can be improved. //cc @dstepanov

@dstepanov
Copy link
Contributor

I'm planning to improve the startup time of serde

@sdelamo
Copy link
Contributor Author

sdelamo commented Feb 1, 2024

personally don't think we should make this change. Instead we should profile startup of serde and see how it can be improved. //cc @dstepanov

Once we have a faster startup in serde we should default to it. But for Serverless, we should default to the fastest settings as many users would evaluate whether to use Micronaut based on cold startup performance.

@dstepanov
Copy link
Contributor

I did some benchmarking, and I cannot see the slower performance of serde:

Benchmark                                                  (stack)  Mode  Cnt  Score   Error  Units
StartupBenchmark.fullStartupAndGetMapper             SERDE_JACKSON    ss   10  0.459 ± 0.022   s/op
StartupBenchmark.fullStartupAndGetMapper          JACKSON_DATABIND    ss   10  0.566 ± 0.060   s/op
StartupBenchmark.fullStartupAndGetMapperReadBean     SERDE_JACKSON    ss   10  0.476 ± 0.047   s/op
StartupBenchmark.fullStartupAndGetMapperReadBean  JACKSON_DATABIND    ss   10  0.599 ± 0.013   s/op
StartupBenchmark.getMapper                           SERDE_JACKSON    ss   10  0.044 ± 0.004   s/op
StartupBenchmark.getMapper                        JACKSON_DATABIND    ss   10  0.143 ± 0.022   s/op
StartupBenchmark.getMapperReadBean                   SERDE_JACKSON    ss   10  0.088 ± 0.013   s/op
StartupBenchmark.getMapperReadBean                JACKSON_DATABIND    ss   10  0.195 ± 0.012   s/op

@dstepanov
Copy link
Contributor

What version did you use in the lambda test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement New feature or request

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

5 participants