Skip to content

More flexible OTLP per meter configuration #6099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lenin-jaganathan opened this issue Apr 8, 2025 · 1 comment · Fixed by #6102
Closed

More flexible OTLP per meter configuration #6099

lenin-jaganathan opened this issue Apr 8, 2025 · 1 comment · Fixed by #6102
Labels
enhancement A general enhancement registry: otlp OpenTelemetry Protocol (OTLP) registry-related
Milestone
1.15.0-RC1

Comments

@lenin-jaganathan
Copy link
Contributor

lenin-jaganathan commented Apr 8, 2025 •
edited
Loading

#5974 introduced the support for configuring HistogramFlavour/buckets per meter for OTLPMeterRegistry. This was done as part of a configuration that was supplied during the registry creation and does not allow overriding via APIs. This configuration does a full match of the meter name and requires the fully qualified meter name to be provided and this can get longer when we need to supply configuration to a family of meters.

Spring boot has a solution to address this issue by supporting the prefix and if there are more values the longest match wins. If users can supply a Function to be applied for determining these values also be an option to try out.
@shakuzen shakuzen added enhancement A general enhancement registry: otlp OpenTelemetry Protocol (OTLP) registry-related and removed waiting-for-triage labels Apr 9, 2025
@shakuzen shakuzen mentioned this issue Apr 9, 2025
Merged
@jonatan-ivanov jonatan-ivanov added this to the 1.15.0-RC1 milestone Apr 10, 2025
@shakuzen shakuzen changed the title Enhance OTLP per meter configuration More flexible OTLP per meter configuration Apr 15, 2025
@shakuzen
Copy link
Member

In the end, we changed the lookup logic to match the mentioned logic used for some Spring Boot configuration properties related to configuring MeterFilters. That is, a longest match by dot-separated segment will be used to apply the per-meter config even in cases where it is not an exact match. See the updated JavaDoc for the methods on OtlpConfig for an example. We did not make this logic customizable, as it didn't seem necessary for the underlying issue (configuring groups of meters). If someone else has the need for that, please let us know the details and we can re-consider that change in a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement A general enhancement registry: otlp OpenTelemetry Protocol (OTLP) registry-related
Projects
None yet
Milestone
1.15.0-RC1
Development

Successfully merging a pull request may close this issue.

Make per-meter OTLP configuration more flexible shakuzen/micrometer
3 participants
@jonatan-ivanov @shakuzen @lenin-jaganathan