Skip to content

Generic/abstract JFR MeterBinder #6065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shakuzen opened this issue Mar 27, 2025 · 0 comments
Open

Generic/abstract JFR MeterBinder #6065

shakuzen opened this issue Mar 27, 2025 · 0 comments
Labels
enhancement A general enhancement module: micrometer-core An issue that is related to our core module
Milestone

Comments

@shakuzen
Copy link
Member

Please describe the feature request.
Provide an abstraction that simplifies and makes a consistent way to provide metrics based on JFR events.

Rationale
There is already VirtualThreadMetrics which is a MeterBinder providing some meters based on JFR events. Expanding on this and customizing this is not easy to do. We may want to add more metrics for JFR events that are added in new versions of Java, related to virtual threads or anything else. We want to avoid duplicating the handling that's currently present in VirtualThreadMetrics and make it easier to customize. It would also make it easy for users to make their own JFR event-based MeterBinder, including for custom JFR events.

Additional context
See #6009 where this came up in trying to add a new meter based on additional JFR events. See also a related (but different) request for a MeterRegistry that produces JFR events: #2273.

@shakuzen shakuzen added enhancement A general enhancement module: micrometer-core An issue that is related to our core module labels Mar 27, 2025
@shakuzen shakuzen added this to the 1.16.0-M1 milestone Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A general enhancement module: micrometer-core An issue that is related to our core module
Projects
None yet
Development

No branches or pull requests

1 participant