Skip to content

Composite meters should ignore Noop children when reporting their value #1537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sfitts opened this issue Aug 1, 2019 · 2 comments
Closed

Composite meters should ignore Noop children when reporting their value #1537

sfitts opened this issue Aug 1, 2019 · 2 comments
Labels
duplicate A duplicate of another issue

Comments

@sfitts
Copy link

sfitts commented Aug 1, 2019

The current implementation of the composite meters is to report their value from the first child. However, if that child is a no-op (because the associated registry denied the meter) then the value reported will be 0. Since it isn't possible for no-op children to have a meaningful value it would seem to make sense to ignore them when reporting the value of a composite and instead report a value from the first non-noop child.
@izeye
Copy link
Contributor

izeye commented Aug 1, 2019

This seems to be a duplicate of #1441.

@sfitts
Copy link
Author

sfitts commented Aug 1, 2019

So it is - sorry -- my search-fu needs improving.

@sfitts sfitts closed this as completed Aug 1, 2019
@izeye izeye added the duplicate A duplicate of another issue label Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate A duplicate of another issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@izeye @sfitts