Fixed local_codechecker errors

Author: mdjnelson

classes/element_helper.php

@@ -477,7 +477,7 @@ public static function get_courseid($elementid) {
      * @param int $elementid The element id
      * @return \context The context
      */
-    public static function get_context(int $elementid) : \context {
+    public static function get_context(int $elementid): \context {
         global $DB;
 
         $sql = "SELECT ct.contextid

classes/privacy/provider.php

@@ -49,7 +49,7 @@ class provider implements
      * @param collection $items a reference to the collection to use to store the metadata.
      * @return collection the updated collection of metadata items.
      */
-    public static function get_metadata(collection $items) : collection {
+    public static function get_metadata(collection $items): collection {
         $items->add_database_table(
             'customcert_issues',
             [
@@ -71,7 +71,7 @@ public static function get_metadata(collection $items) : collection {
      * @param int $userid the userid.
      * @return contextlist the list of contexts containing user info for the user.
      */
-    public static function get_contexts_for_userid(int $userid) : contextlist {
+    public static function get_contexts_for_userid(int $userid): contextlist {
         $sql = "SELECT c.id
                   FROM {context} c
             INNER JOIN {course_modules} cm

element/bgimage/classes/privacy/provider.php

@@ -38,7 +38,7 @@ class provider implements \core_privacy\local\metadata\null_provider {
      *
      * @return  string
      */
-    public static function get_reason() : string {
+    public static function get_reason(): string {
         return 'privacy:metadata';
     }
 }

element/border/classes/privacy/provider.php

@@ -38,7 +38,7 @@ class provider implements \core_privacy\local\metadata\null_provider {
      *
      * @return  string
      */
-    public static function get_reason() : string {
+    public static function get_reason(): string {
         return 'privacy:metadata';
     }
 }

element/categoryname/classes/element.php

@@ -61,7 +61,7 @@ public function render_html() {
      *
      * @return string
      */
-    protected function get_category_name() : string {
+    protected function get_category_name(): string {
         global $DB, $SITE;
 
         $courseid = \mod_customcert\element_helper::get_courseid($this->get_id());

element/categoryname/classes/privacy/provider.php

@@ -38,7 +38,7 @@ class provider implements \core_privacy\local\metadata\null_provider {
      *
      * @return  string
      */
-    public static function get_reason() : string {
+    public static function get_reason(): string {
         return 'privacy:metadata';
     }
 }

element/code/classes/privacy/provider.php

@@ -38,7 +38,7 @@ class provider implements \core_privacy\local\metadata\null_provider {
      *
      * @return  string
      */
-    public static function get_reason() : string {
+    public static function get_reason(): string {
         return 'privacy:metadata';
     }
 }

element/coursefield/classes/element.php

@@ -125,7 +125,7 @@ public function definition_after_data($mform) {
      * @param bool $preview Is this a preview?
      * @return string
      */
-    protected function get_course_field_value(\stdClass $course, bool $preview) : string {
+    protected function get_course_field_value(\stdClass $course, bool $preview): string {
 
         // The user field to display.
         $field = $this->get_data();

element/coursefield/classes/privacy/provider.php

@@ -39,7 +39,7 @@ class provider implements \core_privacy\local\metadata\null_provider {
      *
      * @return  string
      */
-    public static function get_reason() : string {
+    public static function get_reason(): string {
         return 'privacy:metadata';
     }
 }

element/coursename/classes/privacy/provider.php

@@ -38,7 +38,7 @@ class provider implements \core_privacy\local\metadata\null_provider {
      *
      * @return  string
      */
-    public static function get_reason() : string {
+    public static function get_reason(): string {
         return 'privacy:metadata';
     }
 }

element/date/classes/privacy/provider.php

@@ -38,7 +38,7 @@ class provider implements \core_privacy\local\metadata\null_provider {
      *
      * @return  string
      */
-    public static function get_reason() : string {
+    public static function get_reason(): string {
         return 'privacy:metadata';
     }
 }

element/daterange/classes/privacy/provider.php

@@ -38,7 +38,7 @@ class provider implements \core_privacy\local\metadata\null_provider {
      *
      * @return  string
      */
-    public static function get_reason() : string {
+    public static function get_reason(): string {
         return 'privacy:metadata';
     }
 }

element/digitalsignature/classes/privacy/provider.php

@@ -38,7 +38,7 @@ class provider implements \core_privacy\local\metadata\null_provider {
      *
      * @return  string
      */
-    public static function get_reason() : string {
+    public static function get_reason(): string {
         return 'privacy:metadata';
     }
 }

element/grade/classes/privacy/provider.php

@@ -38,7 +38,7 @@ class provider implements \core_privacy\local\metadata\null_provider {
      *
      * @return  string
      */
-    public static function get_reason() : string {
+    public static function get_reason(): string {
         return 'privacy:metadata';
     }
 }

element/gradeitemname/classes/element.php

@@ -144,7 +144,7 @@ public function after_restore($restore) {
      *
      * @return string
      */
-    protected function get_grade_item_name() : string {
+    protected function get_grade_item_name(): string {
         global $DB;
 
         $gradeitem = $this->get_data();

element/gradeitemname/classes/privacy/provider.php

@@ -38,7 +38,7 @@ class provider implements \core_privacy\local\metadata\null_provider {
      *
      * @return  string
      */
-    public static function get_reason() : string {
+    public static function get_reason(): string {
         return 'privacy:metadata';
     }
 }

element/image/classes/privacy/provider.php

@@ -38,7 +38,7 @@ class provider implements \core_privacy\local\metadata\null_provider {
      *
      * @return  string
      */
-    public static function get_reason() : string {
+    public static function get_reason(): string {
         return 'privacy:metadata';
     }
 }

element/qrcode/classes/privacy/provider.php

@@ -38,7 +38,7 @@ class provider implements \core_privacy\local\metadata\null_provider {
      *
      * @return  string
      */
-    public static function get_reason() : string {
+    public static function get_reason(): string {
         return 'privacy:metadata';
     }
 }

element/studentname/classes/privacy/provider.php

@@ -38,7 +38,7 @@ class provider implements \core_privacy\local\metadata\null_provider {
      *
      * @return  string
      */
-    public static function get_reason() : string {
+    public static function get_reason(): string {
         return 'privacy:metadata';
     }
 }

element/teachername/classes/privacy/provider.php

@@ -38,7 +38,7 @@ class provider implements \core_privacy\local\metadata\null_provider {
      *
      * @return  string
      */
-    public static function get_reason() : string {
+    public static function get_reason(): string {
         return 'privacy:metadata';
     }
 }

element/text/classes/element.php

@@ -98,7 +98,7 @@ public function definition_after_data($mform) {
      *
      * @return string
      */
-    protected function get_text() : string {
+    protected function get_text(): string {
         $context = \mod_customcert\element_helper::get_context($this->get_id());
         return format_text($this->get_data(), FORMAT_HTML, ['context' => $context]);
     }

element/text/classes/privacy/provider.php

@@ -38,7 +38,7 @@ class provider implements \core_privacy\local\metadata\null_provider {
      *
      * @return  string
      */
-    public static function get_reason() : string {
+    public static function get_reason(): string {
         return 'privacy:metadata';
     }
 }

element/userfield/classes/element.php

@@ -129,7 +129,7 @@ public function definition_after_data($mform) {
      * @param bool $preview Is this a preview?
      * @return string
      */
-    protected function get_user_field_value(\stdClass $user, bool $preview) : string {
+    protected function get_user_field_value(\stdClass $user, bool $preview): string {
         global $CFG, $DB;
 
         // The user field to display.

element/userfield/classes/privacy/provider.php

@@ -38,7 +38,7 @@ class provider implements \core_privacy\local\metadata\null_provider {
      *
      * @return  string
      */
-    public static function get_reason() : string {
+    public static function get_reason(): string {
         return 'privacy:metadata';
     }
 }

element/userpicture/classes/privacy/provider.php

@@ -38,7 +38,7 @@ class provider implements \core_privacy\local\metadata\null_provider {
      *
      * @return  string
      */
-    public static function get_reason() : string {
+    public static function get_reason(): string {
         return 'privacy:metadata';
     }
 }

version.php

@@ -19,7 +19,7 @@
  *
  * @package    mod_customcert
  * @copyright  2013 Mark Nelson <[email protected]>
- * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or late
+ * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 
 defined('MOODLE_INTERNAL') || die('Direct access to this script is forbidden.');