BUG FIX: Change the way of checking for empty array

Maciek · maciej-barczak-red · commit 280f26b17645 · 2018-08-02T11:30:38.000+02:00
The original condition : attachments !== [] always returns true,
for empty array, as well as for array with elements.
diff --git a/browser/main/lib/dataApi/attachmentManagement.js b/browser/main/lib/dataApi/attachmentManagement.js
@@ -84,7 +84,7 @@ function createAttachmentDestinationFolder (destinationStoragePath, noteKey) {
 function migrateAttachments (markdownContent, storagePath, noteKey) {
   if (noteKey !== undefined && sander.existsSync(path.join(storagePath, 'images'))) {
     const attachments = getAttachmentsInMarkdownContent(markdownContent) || []
-    if (attachments !== []) {
+    if (attachments.length) {
       createAttachmentDestinationFolder(storagePath, noteKey)
     }
     for (const attachment of attachments) {

Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@ function createAttachmentDestinationFolder (destinationStoragePath, noteKey) {`
`84`	`84`	`function migrateAttachments (markdownContent, storagePath, noteKey) {`
`85`	`85`	`if (noteKey !== undefined && sander.existsSync(path.join(storagePath, 'images'))) {`
`86`	`86`	`const attachments = getAttachmentsInMarkdownContent(markdownContent) \|\| []`
`87`		`- if (attachments !== []) {`
	`87`	`+ if (attachments.length) {`
`88`	`88`	`createAttachmentDestinationFolder(storagePath, noteKey)`
`89`	`89`	`}`
`90`	`90`	`for (const attachment of attachments) {`