Bug: Crash when an account is deleted

[jakubkottnauer]

Before you start (required)

General checklist

• I have removed personal / sensitive data from screenshots and logs
• I have searched existing issues and discussions to ensure this is not a duplicate issue

How are you using Maybe?

• I am a paying Maybe customer (hosted version)
  • Paying Maybe users can also open requests in Intercom (if there is sensitive info involved)
• I am a self-hosted user

Self hoster checklist

• Self hosted app commit SHA (find in user menu): a3cd5f4
  • I have confirmed that my app's commit is the latest version of Maybe
• Where are you hosting?
  • Render
  • Docker Compose
  • Umbrel
  • Other (please specify)

---

Bug description

When you delete an account, Maybe crashes. Sentry stack trace attached below.

To Reproduce

1. Create a new account
2. Try to delete

Expected behavior

It should be possible to delete accounts without errors

Screenshots and/or recordings

[zachgoll]

@jakubkottnauer are you able to reproduce this with a brand new account reliably? I can't get this to work on my end with the supplied repro steps:

CleanShot.2025-03-11.at.10.30.12.mp4

[jakubkottnauer]

@zachgoll yup, can consistently reproduce this. I've recorded a video:

Kapture.2025-03-12.at.17.00.49.mp4

[zachgoll]

@jakubkottnauer I'm following those exact steps and not getting the error locally and in my fresh self hosted instance, which tells me that this has something to do with the data that is in your database.

What does this return for you?

SELECT DISTINCT accountable_type FROM accounts;

I'd be looking for any NULL values (which would indicate the problem).

[jakubkottnauer]

Oh yes, there's a thing I forgot to mention - the app loads just fine when I refresh the page after the crash 😄 My bad for missing out this crucial piece of info. That means any potential NULL values there would only be there for a split second, if at all.

I see how you're thinking, considering that it crashes on this line <%= circle_logo(account.name, hex: color || account.accountable.color, size: size) %>

Attaching what the output of the query looks like, but yeah, no NULLs as expected:

I can try debugging this locally later this week.

[zachgoll]

@jakubkottnauer hmmm, that's interesting. It's almost as if account.destroy is not running in a DB transaction and the accountable is first deleted, the error happens, then the account is deleted.

As far as I'm aware, ActiveRecord already wraps destroy methods in a transaction? But maybe that assumption is wrong, which might explain this.