Remove unnecessary unittest.TestCase subclassing (#3718)

* rename QuasiHarmonicDebyeApprox and deprecate old class

* remove unnecessary subclassing of unittest.TestCase

Author: janosh

pymatgen/analysis/quasiharmonic.py

@@ -14,6 +14,7 @@
 from collections import defaultdict
 
 import numpy as np
+from monty.dev import deprecated
 from scipy.constants import physical_constants
 from scipy.integrate import quadrature
 from scipy.misc import derivative
@@ -45,7 +46,7 @@
     "temperature, and Grüneisen parameter using a quasiharmonic Debye model",
     path="pymatgen.analysis.quasiharmonic",
 )
-class QuasiharmonicDebyeApprox:
+class QuasiHarmonicDebyeApprox:
     """Quasi-harmonic approximation."""
 
     def __init__(
@@ -356,3 +357,12 @@ def get_summary_dict(self):
             dct["gruneisen_parameter"].append(self.gruneisen_parameter(t, v))
             dct["thermal_conductivity"].append(self.thermal_conductivity(t, v))
         return dct
+
+
+@deprecated(
+    replacement=QuasiHarmonicDebyeApprox,
+    message="Use PascalCased QuasiHarmonicDebyeApprox instead. "
+    "Deprecated on 2024-03-27, to be removed on 2025-03-27.",
+)
+class QuasiharmonicDebyeApprox(QuasiHarmonicDebyeApprox):
+    pass

pymatgen/util/testing/__init__.py

@@ -10,9 +10,9 @@
 import json
 import pickle  # use pickle, not cPickle so that we get the traceback in case of errors
 import string
-import unittest
 from pathlib import Path
 from typing import TYPE_CHECKING, Any, ClassVar
+from unittest import TestCase
 
 import pytest
 from monty.json import MontyDecoder, MSONable
@@ -34,7 +34,7 @@
 FAKE_POTCAR_DIR = f"{VASP_IN_DIR}/fake_potcars"
 
 
-class PymatgenTest(unittest.TestCase):
+class PymatgenTest(TestCase):
     """Extends unittest.TestCase with several assert methods for array and str comparison."""
 
     # dict of lazily-loaded test structures (initialized to None)

tests/alchemy/test_filters.py

@@ -1,7 +1,7 @@
 from __future__ import annotations
 
 import json
-import unittest
+from unittest import TestCase
 
 from monty.json import MontyDecoder
 
@@ -70,7 +70,7 @@ def test_as_from_dict(self):
         assert isinstance(SpecieProximityFilter.from_dict(dct), SpecieProximityFilter)
 
 
-class TestRemoveDuplicatesFilter(unittest.TestCase):
+class TestRemoveDuplicatesFilter(TestCase):
     def setUp(self):
         with open(f"{TEST_FILES_DIR}/TiO2_entries.json") as file:
             entries = json.load(file, cls=MontyDecoder)
@@ -89,7 +89,7 @@ def test_as_from_dict(self):
         assert isinstance(RemoveDuplicatesFilter().from_dict(dct), RemoveDuplicatesFilter)
 
 
-class TestRemoveExistingFilter(unittest.TestCase):
+class TestRemoveExistingFilter(TestCase):
     def setUp(self):
         with open(f"{TEST_FILES_DIR}/TiO2_entries.json") as file:
             entries = json.load(file, cls=MontyDecoder)

tests/analysis/chemenv/utils/test_func_utils.py

@@ -1,7 +1,5 @@
 from __future__ import annotations
 
-import unittest
-
 import numpy as np
 import pytest
 from pytest import approx
@@ -15,7 +13,7 @@
 __author__ = "waroquiers"
 
 
-class TestFuncUtils(unittest.TestCase):
+class TestFuncUtils:
     def test_csm_finite_ratio_function(self):
         max_csm = 8
         alpha = 1

tests/analysis/magnetism/test_analyzer.py

@@ -1,7 +1,7 @@
 from __future__ import annotations
 
-import unittest
 from shutil import which
+from unittest import TestCase
 
 import pytest
 from monty.serialization import loadfn
@@ -22,7 +22,7 @@
 enumlib_present = enum_cmd and makestr_cmd
 
 
-class TestCollinearMagneticStructureAnalyzer(unittest.TestCase):
+class TestCollinearMagneticStructureAnalyzer(TestCase):
     def setUp(self):
         self.Fe = Structure.from_file(f"{TEST_FILES_DIR}/Fe.cif", primitive=True)
 
@@ -243,7 +243,7 @@ def test_missing_spin(self):
         assert msa.structure.site_properties["magmom"] == [-5, 5, 0, 0]
 
 
-class TestMagneticStructureEnumerator(unittest.TestCase):
+class TestMagneticStructureEnumerator:
     @pytest.mark.skipif(not enumlib_present, reason="enumlib not present")
     def test_ordering_enumeration(self):
         # simple afm
@@ -282,7 +282,7 @@ def test_ordering_enumeration(self):
         assert enumerator.input_origin == "afm_by_motif_2a"
 
 
-class TestMagneticDeformation(unittest.TestCase):
+class TestMagneticDeformation:
     def test_magnetic_deformation(self):
         test_structs = loadfn(f"{TEST_FILES_DIR}/magnetic_deformation.json")
         mag_def = magnetic_deformation(test_structs[0], test_structs[1])

tests/analysis/magnetism/test_heisenberg.py

@@ -1,6 +1,6 @@
 from __future__ import annotations
 
-import unittest
+from unittest import TestCase
 
 import pandas as pd
 
@@ -11,7 +11,7 @@
 TEST_DIR = f"{TEST_FILES_DIR}/magnetic_orderings"
 
 
-class TestHeisenbergMapper(unittest.TestCase):
+class TestHeisenbergMapper(TestCase):
     @classmethod
     def setUpClass(cls):
         cls.df = pd.read_json(f"{TEST_DIR}/mag_orderings_test_cases.json")
@@ -31,9 +31,6 @@ def setUpClass(cls):
             hm = HeisenbergMapper(ordered_structures, energies, cutoff=5.0, tol=0.02)
             cls.hms.append(hm)
 
-    def setUp(self):
-        pass
-
     def test_graphs(self):
         for hm in self.hms:
             struct_graphs = hm.sgraphs

tests/analysis/magnetism/test_jahnteller.py

@@ -1,6 +1,6 @@
 from __future__ import annotations
 
-import unittest
+from unittest import TestCase
 
 import numpy as np
 from pytest import approx
@@ -10,7 +10,7 @@
 from pymatgen.util.testing import TEST_FILES_DIR
 
 
-class TestJahnTeller(unittest.TestCase):
+class TestJahnTeller(TestCase):
     def setUp(self):
         self.jt = JahnTellerAnalyzer()
 

tests/analysis/structure_prediction/test_dopant_predictor.py

@@ -1,6 +1,6 @@
 from __future__ import annotations
 
-import unittest
+from unittest import TestCase
 
 from pytest import approx
 
@@ -12,7 +12,7 @@
 from pymatgen.core import Species, Structure
 
 
-class TestDopantPrediction(unittest.TestCase):
+class TestDopantPrediction(TestCase):
     def setUp(self):
         self.tin_dioxide = Structure(
             [3.24, 0, 0, 0, 4.83, 0, 0, 0, 4.84],

tests/analysis/structure_prediction/test_substitution_probability.py

@@ -1,7 +1,7 @@
 from __future__ import annotations
 
 import json
-import unittest
+from unittest import TestCase
 
 from pytest import approx
 
@@ -24,7 +24,7 @@ def get_table():
         return json.load(file)
 
 
-class TestSubstitutionProbability(unittest.TestCase):
+class TestSubstitutionProbability(TestCase):
     def test_full_lambda_table(self):
         """
         This test tests specific values in the data folder. If the
@@ -56,7 +56,7 @@ def test_mini_lambda_table(self):
         assert prob == approx(0.00102673915742, abs=1e-5), "probability isn't correct"
 
 
-class TestSubstitutionPredictor(unittest.TestCase):
+class TestSubstitutionPredictor(TestCase):
     def test_prediction(self):
         sp = SubstitutionPredictor(threshold=8e-3)
         result = sp.list_prediction(["Na+", "Cl-"], to_this_composition=True)[5]

tests/analysis/test_bond_dissociation.py

@@ -1,7 +1,7 @@
 from __future__ import annotations
 
 import os
-import unittest
+from unittest import TestCase
 
 import pytest
 from monty.serialization import loadfn
@@ -11,7 +11,7 @@
 module_dir = os.path.dirname(os.path.abspath(__file__))
 
 
-class TestBondDissociation(unittest.TestCase):
+class TestBondDissociation(TestCase):
     def setUp(self):
         pytest.importorskip("openbabel")
         self.PC_65_principle = loadfn(f"{module_dir}/PC_65_principle.json")