Update IsoSpriteSortingEditor to use SerializedProperties

Update Line Drawing

Author: markv12

Assets/Scenes/DemoScene.unity

@@ -226,8 +226,8 @@ MonoBehaviour:
   isMovable: 1
   renderBelowAll: 0
   sortType: 0
-  SorterPositionOffset: {x: 0, y: -1.6350486, z: 0}
-  SorterPositionOffset2: {x: 0, y: 0, z: 0}
+  SorterPositionOffset: {x: 0, y: -1.6350486}
+  SorterPositionOffset2: {x: 0, y: 0}
   renderersToSort:
   - {fileID: 390935947}
 --- !u!58 &390935950
@@ -344,8 +344,8 @@ MonoBehaviour:
   isMovable: 1
   renderBelowAll: 0
   sortType: 1
-  SorterPositionOffset: {x: 2.2763543, y: 0.1265924, z: 0}
-  SorterPositionOffset2: {x: -2.3427062, y: -1.3827682, z: 0}
+  SorterPositionOffset: {x: 2.2763543, y: 0.1265924}
+  SorterPositionOffset2: {x: -2.3427062, y: -1.3827682}
   renderersToSort:
   - {fileID: 516553217}
 --- !u!212 &516553217
@@ -408,7 +408,7 @@ Transform:
   m_PrefabAsset: {fileID: 0}
   m_GameObject: {fileID: 516553214}
   m_LocalRotation: {x: 0, y: 0, z: 0, w: 1}
-  m_LocalPosition: {x: -6.36, y: -0.94, z: 13.285156}
+  m_LocalPosition: {x: -6.36, y: -0.94, z: 0}
   m_LocalScale: {x: 1, y: 1, z: 1}
   m_ConstrainProportionsScale: 0
   m_Children: []
@@ -478,8 +478,8 @@ MonoBehaviour:
   isMovable: 1
   renderBelowAll: 0
   sortType: 1
-  SorterPositionOffset: {x: 2.3606417, y: -1.3737345, z: 0}
-  SorterPositionOffset2: {x: -2.3105102, y: 0.19493532, z: 0}
+  SorterPositionOffset: {x: 2.3606417, y: -1.3737345}
+  SorterPositionOffset2: {x: -2.3105102, y: 0.19493532}
   renderersToSort:
   - {fileID: 548565859}
 --- !u!212 &548565859
@@ -542,7 +542,7 @@ Transform:
   m_PrefabAsset: {fileID: 0}
   m_GameObject: {fileID: 548565856}
   m_LocalRotation: {x: 0, y: 0, z: 0, w: 1}
-  m_LocalPosition: {x: 2.8, y: -2.28, z: 13.285156}
+  m_LocalPosition: {x: 2.8, y: -2.28, z: 0}
   m_LocalScale: {x: 1, y: 1, z: 1}
   m_ConstrainProportionsScale: 0
   m_Children: []
@@ -745,8 +745,8 @@ MonoBehaviour:
   isMovable: 1
   renderBelowAll: 0
   sortType: 0
-  SorterPositionOffset: {x: 0.12794042, y: -2.6825585, z: 0}
-  SorterPositionOffset2: {x: 0, y: 0, z: 0}
+  SorterPositionOffset: {x: 0.12794042, y: -2.6825585}
+  SorterPositionOffset2: {x: 0, y: 0}
   renderersToSort:
   - {fileID: 1750251657}
 --- !u!212 &1750251657
@@ -809,7 +809,7 @@ Transform:
   m_PrefabAsset: {fileID: 0}
   m_GameObject: {fileID: 1750251654}
   m_LocalRotation: {x: 0, y: 0, z: 0, w: 1}
-  m_LocalPosition: {x: -3.78, y: -0.1, z: 13.285156}
+  m_LocalPosition: {x: -3.78, y: -0.1, z: 0}
   m_LocalScale: {x: 1, y: 1, z: 1}
   m_ConstrainProportionsScale: 0
   m_Children: []
@@ -866,8 +866,8 @@ MonoBehaviour:
   isMovable: 1
   renderBelowAll: 0
   sortType: 0
-  SorterPositionOffset: {x: 0.12794018, y: -2.6825585, z: 0}
-  SorterPositionOffset2: {x: 0, y: 0, z: 0}
+  SorterPositionOffset: {x: 0.12794018, y: -2.6825585}
+  SorterPositionOffset2: {x: 0, y: 0}
   renderersToSort:
   - {fileID: 1786415549}
 --- !u!212 &1786415549
@@ -930,7 +930,7 @@ Transform:
   m_PrefabAsset: {fileID: 0}
   m_GameObject: {fileID: 1786415546}
   m_LocalRotation: {x: 0, y: 0, z: 0, w: 1}
-  m_LocalPosition: {x: 5.65, y: 0.84, z: 13.285156}
+  m_LocalPosition: {x: 5.65, y: 0.84, z: 0}
   m_LocalScale: {x: 1, y: 1, z: 1}
   m_ConstrainProportionsScale: 0
   m_Children: []

Assets/Scripts/IsoSpriteSortingEditor.cs

@@ -6,29 +6,39 @@
 
 [CustomEditor(typeof(IsoSpriteSorting))]
 public class IsoSpriteSortingEditor : Editor {
+    SerializedProperty sorterPositionOffset;
+    SerializedProperty sorterPositionOffset2;
+
+    private void OnEnable() {
+        sorterPositionOffset = serializedObject.FindProperty("SorterPositionOffset");
+        sorterPositionOffset2 = serializedObject.FindProperty("SorterPositionOffset2");
+    }
+
     public void OnSceneGUI() {
-        IsoSpriteSorting myTarget = (IsoSpriteSorting)target;
+        IsoSpriteSorting sorter = (IsoSpriteSorting)target;
 
-        myTarget.SorterPositionOffset = Handles.FreeMoveHandle(
-            myTarget.transform.position + (Vector3)myTarget.SorterPositionOffset,
+        serializedObject.Update();
+        EditorGUI.BeginChangeCheck();
+        sorterPositionOffset.vector2Value = Handles.FreeMoveHandle(
+            sorter.transform.position + (Vector3)sorterPositionOffset.vector2Value,
             Quaternion.identity,
-            0.08f * HandleUtility.GetHandleSize(myTarget.transform.position),
+            0.08f * HandleUtility.GetHandleSize(sorter.transform.position),
             Vector3.zero,
             Handles.DotHandleCap
-        ) - myTarget.transform.position;
-        if (myTarget.sortType == IsoSpriteSorting.SortType.Line) {
-            myTarget.SorterPositionOffset2 = Handles.FreeMoveHandle(
-                myTarget.transform.position + (Vector3)myTarget.SorterPositionOffset2,
+        ) - sorter.transform.position;
+        if (sorter.sortType == IsoSpriteSorting.SortType.Line) {
+            sorterPositionOffset2.vector2Value = Handles.FreeMoveHandle(
+                sorter.transform.position + (Vector3)sorterPositionOffset2.vector2Value,
                 Quaternion.identity,
-                0.08f * HandleUtility.GetHandleSize(myTarget.transform.position),
+                0.08f * HandleUtility.GetHandleSize(sorter.transform.position),
                 Vector3.zero,
                 Handles.DotHandleCap
-            ) - myTarget.transform.position;
-            Handles.DrawLine(myTarget.transform.position + (Vector3)myTarget.SorterPositionOffset, myTarget.transform.position + (Vector3)myTarget.SorterPositionOffset2);
+            ) - sorter.transform.position;
+            Vector2 pos = sorter.transform.position;
+            Handles.DrawLine(pos + sorterPositionOffset.vector2Value, pos + sorterPositionOffset2.vector2Value);
         }
-        if (GUI.changed) {
-            Undo.RecordObject(target, "Updated Sorting Offset");
-            EditorUtility.SetDirty(target);
+        if (EditorGUI.EndChangeCheck()) {
+            serializedObject.ApplyModifiedProperties();
         }
     }