Skip to content

Commit 243db65

Browse files
committed
Fix Issue #13
* Remove dependencies on meta package * Add version constraints on dependencies
1 parent 3d54d09 commit 243db65

File tree

6 files changed

+13
-14
lines changed

6 files changed

+13
-14
lines changed

CHANGELOG.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,12 @@
11
Changelog
22
================
33

4-
## Version 0.3.3 (2013-07-??) ##
4+
## Version 0.3.4 (2013-10-08) ##
5+
* Fix Issue #13: html5_dnd is incompatible with js-interop and the latest SDK
6+
* Remove dependencies on meta package
7+
* Add version constraints on dependencies
8+
9+
## Version 0.3.3 (2013-07-09) ##
510
* Support dragging of SVG elements (Issue #7). Dragging of SVG elements uses the
611
emulated mode in all browsers.
712
* Add tests for dragging SVG elements.

lib/html5_dnd.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,10 @@ import 'dart:html';
88
import 'dart:async';
99
import 'dart:math' as math;
1010
import 'dart:svg' as svg;
11-
import 'package:meta/meta.dart';
1211
import 'package:logging/logging.dart';
1312

1413
import 'src/utils.dart' as utils;
1514

16-
import 'src/sortable/sortable.dart';
1715
export 'src/sortable/sortable.dart';
1816

1917
part 'src/dnd/group.dart';

lib/src/sortable/sortable.dart

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ library html5_dnd.sortable;
66

77
import 'dart:html';
88
import 'dart:async';
9-
import 'package:meta/meta.dart';
109
import 'package:logging/logging.dart';
1110

1211
import '../../html5_dnd.dart';
@@ -127,7 +126,6 @@ class SortableGroup extends DraggableGroup implements DropzoneGroup {
127126
/**
128127
* Installs sortable behaviour on [element] and registers it in this group.
129128
*/
130-
@override
131129
void install(Element element) {
132130
_logger.finest('installing as sortable');
133131
// Sortable elements are at the same time draggables (superclass) and dropzones.
@@ -232,15 +230,13 @@ class Position {
232230
parent.children.insert(index, element);
233231
}
234232

235-
@override
236233
int get hashCode {
237234
int result = 17;
238235
result = 37 * result + parent.hashCode;
239236
result = 37 * result + index.hashCode;
240237
return result;
241238
}
242239

243-
@override
244240
bool operator ==(other) {
245241
if (identical(other, this)) return true;
246242
return (other is Position

lib/src/utils.dart

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,9 @@ int getElementIndexInParent(Element element) {
3131
void clearTextSelections() {
3232
window.getSelection().removeAllRanges();
3333
var activeElement = document.activeElement;
34-
if (activeElement is TextAreaElement || activeElement is InputElement) {
34+
if (activeElement is TextAreaElement) {
35+
activeElement.setSelectionRange(0, 0);
36+
} else if (activeElement is InputElement) {
3537
activeElement.setSelectionRange(0, 0);
3638
}
3739
}

pubspec.yaml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,11 @@
11
name: html5_dnd
2-
version: 0.3.3
2+
version: 0.3.4
33
author: Marco Jakob <[email protected]>
44
description: HTML5 Drag and Drop
55
homepage: https://github.com/marcojakob/dart-html5-dnd
66
documentation: http://edu.makery.ch/projects/dart-html5-drag-and-drop
77
dependencies:
8-
logging: any
9-
meta: any
8+
logging: '>=0.7.6'
109
dev_dependencies:
11-
browser: any
12-
logging_handlers: any
10+
browser: '>=0.7.6'
11+
logging_handlers: '>=0.5.0'

test/svg/svg_test.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
library svt_test;
55

66
import 'dart:html';
7-
import 'dart:svg' as svg;
87

98
import 'package:logging_handlers/logging_handlers_shared.dart';
109
import 'package:logging/logging.dart';

0 commit comments

Comments
 (0)