-
Notifications
You must be signed in to change notification settings - Fork 31
Add accounts tokens endpoints (work by @morgant) #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@morgant Thoughts on these failing tests? I don't think they are related to a missing token; that appears to be correctly being pulled as an environment variable. I haven't looked deeply due to time constraints. Let me know if you think it's something on the admin side. |
|
@samfader Thanks for your continued work on this! Looking at the Travis CI job log, I don't see the new |
|
Hey @morgant, thanks for your patience. I've been meaning to come back to this for a while. I've decided that the best approach will be to mock these tests - I don't feel great about creating and deleting tokens on a real account. I'm looking into this approach now. |
|
Just re-upping this as a feature request, it's been "almost mergeable" as a feature across two different PRs for a few years now. |
@morgant Per #43 (comment), putting your PR in here with a local branch to ensure tests pass.