Fix incorrect initial puck position (#3773)

* Fix incorrect initial puck position

* Add changelog

Author: S2Ler

CHANGELOG.md

@@ -26,6 +26,7 @@
 * Fixed an issue where the route line appeared to begin away from the user’s current location after the route was refreshed. ([#3781](https://github.com/mapbox/mapbox-navigation-ios/pull/3781))
 * Fixed a memory leak after ending a turn-by-turn navigation session. ([#3782](https://github.com/mapbox/mapbox-navigation-ios/pull/3782))
 * Fixed an issue when `SimulatedLocationManager` could freeze the main thread when working with long routes. The manager now calls delegate methods from a background thread. ([#3672](https://github.com/mapbox/mapbox-navigation-ios/pull/3672))
+* Fixed an issue where initial puck position can be incorrect when `NavigationViewController` is presented. ([#3773](https://github.com/mapbox/mapbox-navigation-ios/pull/3773))
 
 ### Offline routing
 

Sources/MapboxNavigation/CarPlayNavigationViewController.swift

@@ -393,8 +393,8 @@ open class CarPlayNavigationViewController: UIViewController, BuildingHighlighti
     public override func viewDidLoad() {
         super.viewDidLoad()
 
-        setupNavigationMapView()
         setupOrnaments()
+        setupNavigationMapView()
         setupStyleManager()
 
         observeNotifications(navigationService)

Sources/MapboxNavigation/NavigationMapView.swift

@@ -1863,7 +1863,7 @@ open class NavigationMapView: UIView {
      */
     func setInitialCamera(_ coordinate: CLLocationCoordinate2D) {
         guard let navigationViewportDataSource = navigationCamera.viewportDataSource as? NavigationViewportDataSource else { return }
-        
+        layoutIfNeeded() // mapView isn't able to properly convert coordinates before layout.
         mapView.mapboxMap.setCamera(to: CameraOptions(center: coordinate,
                                                       zoom: CGFloat(navigationViewportDataSource.options.followingCameraOptions.zoomRange.upperBound)))
         moveUserLocation(to: CLLocation(latitude: coordinate.latitude, longitude: coordinate.longitude))