Skip to content
This repository was archived by the owner on Feb 20, 2023. It is now read-only.

Commit 9a0134c

Browse files
brianmageplazabrianmageplaza
authored
Merge pull request #25 from mageplaza/2.3-develop
Clean code
2 parents 2894348 + 99bfe2a commit 9a0134c

File tree

6 files changed

+108
-108
lines changed

6 files changed

+108
-108
lines changed

‎.github/ISSUE_TEMPLATE/bug_report.md‎

Lines changed: 34 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -1,34 +1,34 @@
1-
---
2-
name: Bug report
3-
about: Technical issue with the extension
4-
labels: 'Issue'
5-
6-
---
7-
8-
<!---
9-
Fields marked with (*) are required. Please don't remove the template.
10-
-->
11-
12-
### Preconditions (*)
13-
<!---
14-
Provide the exact Magento version (example: 2.4.0) and any important information on the environment where bug is reproducible.
15-
-->
16-
1.
17-
2.
18-
19-
### Steps to reproduce (*)
20-
<!---
21-
Important: Provide a set of clear steps to reproduce this bug. We can not provide support without clear instructions on how to reproduce.
22-
-->
23-
1.
24-
2.
25-
26-
### Expected result (*)
27-
<!--- Tell us what do you expect to happen. -->
28-
1. [Screenshots, logs or description]
29-
2.
30-
31-
### Actual result (*)
32-
<!--- Tell us what happened instead. Include error messages and issues. -->
33-
1. [Screenshots, logs or description]
34-
2.
1+
---
2+
name: Bug report
3+
about: Technical issue with the extension
4+
labels: 'Issue'
5+
6+
---
7+
8+
<!---
9+
Fields marked with (*) are required. Please don't remove the template.
10+
-->
11+
12+
### Preconditions (*)
13+
<!---
14+
Provide the exact Magento version (example: 2.4.0) and any important information on the environment where bug is reproducible.
15+
-->
16+
1.
17+
2.
18+
19+
### Steps to reproduce (*)
20+
<!---
21+
Important: Provide a set of clear steps to reproduce this bug. We can not provide support without clear instructions on how to reproduce.
22+
-->
23+
1.
24+
2.
25+
26+
### Expected result (*)
27+
<!--- Tell us what do you expect to happen. -->
28+
1. [Screenshots, logs or description]
29+
2.
30+
31+
### Actual result (*)
32+
<!--- Tell us what happened instead. Include error messages and issues. -->
33+
1. [Screenshots, logs or description]
34+
2.

‎.github/ISSUE_TEMPLATE/developer-experience-issue.md‎

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,19 @@
1-
---
2-
name: Developer experience issue
3-
about: Issues related to customization, extensibility, modularity
4-
labels: 'Experience'
5-
6-
---
7-
8-
<!---
9-
Fields marked with (*) are required. Please don't remove the template.
10-
-->
11-
12-
### Summary (*)
13-
<!--- Describe the issue you are experiencing. Include general information, error messages, environments, and so on. -->
14-
15-
### Examples (*)
16-
<!--- Provide code examples or a patch with a test (recommended) to clearly indicate the problem. -->
17-
18-
### Proposed solution
19-
<!--- Suggest your potential solutions for this issue. -->
1+
---
2+
name: Developer experience issue
3+
about: Issues related to customization, extensibility, modularity
4+
labels: 'Experience'
5+
6+
---
7+
8+
<!---
9+
Fields marked with (*) are required. Please don't remove the template.
10+
-->
11+
12+
### Summary (*)
13+
<!--- Describe the issue you are experiencing. Include general information, error messages, environments, and so on. -->
14+
15+
### Examples (*)
16+
<!--- Provide code examples or a patch with a test (recommended) to clearly indicate the problem. -->
17+
18+
### Proposed solution
19+
<!--- Suggest your potential solutions for this issue. -->

‎.github/ISSUE_TEMPLATE/feature_request.md‎

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,22 @@
1-
---
2-
name: Feature request
3-
about: Request feature for development
4-
labels: 'Feature Request'
5-
6-
---
7-
8-
<!---
9-
Fields marked with (*) are required. Please don't remove the template.
10-
-->
11-
12-
### Description (*)
13-
<!--- Describe the feature you would like to add. -->
14-
15-
### Expected behavior (*)
16-
<!--- What is the expected behavior of this feature? How is it going to work? -->
17-
18-
### Benefits
19-
<!--- How do you think this feature would improve the extension? -->
20-
21-
### Additional information
22-
<!--- What other information can you provide about the desired feature? -->
1+
---
2+
name: Feature request
3+
about: Request feature for development
4+
labels: 'Feature Request'
5+
6+
---
7+
8+
<!---
9+
Fields marked with (*) are required. Please don't remove the template.
10+
-->
11+
12+
### Description (*)
13+
<!--- Describe the feature you would like to add. -->
14+
15+
### Expected behavior (*)
16+
<!--- What is the expected behavior of this feature? How is it going to work? -->
17+
18+
### Benefits
19+
<!--- How do you think this feature would improve the extension? -->
20+
21+
### Additional information
22+
<!--- What other information can you provide about the desired feature? -->

‎.github/PULL_REQUEST_TEMPLATE.md‎

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,19 @@
1-
<!--- Provide a general summary of the Pull Request in the Title above -->
2-
3-
### Description
4-
<!--- Provide a description of the changes proposed in the pull request -->
5-
6-
### Fixed Issues (if relevant)
7-
<!--- Provide a list of fixed issues in the format magento/magento2#<issue_number>, if relevant -->
8-
1. https://github.com/mageplaza/magento-2-reports/<issue_number>: Issue title
9-
2. ...
10-
11-
### Manual testing scenarios
12-
<!--- Provide a set of unambiguous steps to test the proposed code change -->
13-
1.
14-
2.
15-
16-
### Contribution checklist
17-
- [ ] Pull request has a meaningful description of its purpose
18-
- [ ] All commits are accompanied by meaningful commit messages
19-
- [ ] All new or changed code is covered with unit/integration tests (if applicable)
1+
<!--- Provide a general summary of the Pull Request in the Title above -->
2+
3+
### Description
4+
<!--- Provide a description of the changes proposed in the pull request -->
5+
6+
### Fixed Issues (if relevant)
7+
<!--- Provide a list of fixed issues in the format magento/magento2#<issue_number>, if relevant -->
8+
1. https://github.com/mageplaza/magento-2-reports/<issue_number>: Issue title
9+
2. ...
10+
11+
### Manual testing scenarios
12+
<!--- Provide a set of unambiguous steps to test the proposed code change -->
13+
1.
14+
2.
15+
16+
### Contribution checklist
17+
- [ ] Pull request has a meaningful description of its purpose
18+
- [ ] All commits are accompanied by meaningful commit messages
19+
- [ ] All new or changed code is covered with unit/integration tests (if applicable)

‎.github/no-response.yml‎

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
1-
# Configuration for probot-no-response - https://github.com/probot/no-response
2-
3-
# Number of days of inactivity before an Issue is closed for lack of response
4-
daysUntilClose: 7
5-
# Label requiring a response
6-
responseRequiredLabel: waiting-customer-response
7-
# Comment to post when closing an Issue for lack of response. Set to `false` to disable
8-
closeComment: >
9-
This issue has been automatically closed because there has been no response
10-
to our request for more information from the original author. With only the
11-
information that is currently in the issue, we don't have enough information
12-
to take action. Please reach out if you have or find the answers we need so
13-
that we can investigate further.
1+
# Configuration for probot-no-response - https://github.com/probot/no-response
2+
3+
# Number of days of inactivity before an Issue is closed for lack of response
4+
daysUntilClose: 7
5+
# Label requiring a response
6+
responseRequiredLabel: waiting-customer-response
7+
# Comment to post when closing an Issue for lack of response. Set to `false` to disable
8+
closeComment: >
9+
This issue has been automatically closed because there has been no response
10+
to our request for more information from the original author. With only the
11+
information that is currently in the issue, we don't have enough information
12+
to take action. Please reach out if you have or find the answers we need so
13+
that we can investigate further.

‎composer.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"mageplaza/module-core": "^1.4.5"
66
},
77
"type": "magento2-module",
8-
"version": "1.0.5",
8+
"version": "1.0.6",
99
"license": "proprietary",
1010
"authors": [
1111
{

0 commit comments

Comments
 (0)