Fix MirrorMeterReading reading time period aligns to minute boundaries

Instead of using the sample data to calculate the time period which may be subject to sampling latency and not align to minute boundaries

Fix for CACTUS test

Author: longzheng

src/coordinator/helpers/sampleBase.ts

@@ -1,29 +1,3 @@
 export type SampleBase = {
     date: Date;
 };
-
-export type SampleTimePeriod = {
-    start: Date;
-    end: Date;
-    durationSeconds: number;
-};
-
-export function getSampleTimePeriod<T extends SampleBase>(
-    samples: T[],
-): SampleTimePeriod {
-    if (samples.length === 0) {
-        throw new Error('No samples to calculate time period');
-    }
-
-    const start = samples.at(0)!.date;
-    const end = samples.at(-1)!.date;
-    const durationSeconds = Math.round(
-        (end.getTime() - start.getTime()) / 1000,
-    );
-
-    return {
-        start,
-        end,
-        durationSeconds,
-    };
-}

src/sep2/helpers/mirrorUsagePointBase.ts

@@ -14,7 +14,6 @@ import { objectToXml } from './xml.js';
 import { type Logger } from 'pino';
 import { numberWithPow10 } from '../../helpers/number.js';
 import { type SampleBase } from '../../coordinator/helpers/sampleBase.js';
-import { getSampleTimePeriod } from '../../coordinator/helpers/sampleBase.js';
 import { objectEntriesWithType } from '../../helpers/object.js';
 import { addMilliseconds } from 'date-fns';
 import { isNetworkError, isRetryableError } from 'axios-retry';
@@ -181,13 +180,11 @@ export abstract class MirrorUsagePointHelperBase<
         // we won't know what reading types we have
         if (samples.length > 0) {
             const now = new Date();
+            const nextUpdateMilliseconds = getNextUpdateMilliseconds();
             const reading = this.getReadingFromSamples(samples);
-            const sampleTimePeriod = getSampleTimePeriod(samples);
+            const sampleDurationSeconds = nextUpdateMilliseconds / 1000;
             const lastUpdateTime = now;
-            const nextUpdateTime = addMilliseconds(
-                now,
-                getNextUpdateMilliseconds(),
-            );
+            const nextUpdateTime = addMilliseconds(now, nextUpdateMilliseconds);
             const mirrorMeterReadings = this.getReadingValues({
                 reading,
             });
@@ -219,8 +216,8 @@ export abstract class MirrorUsagePointHelperBase<
                             ),
 
                             timePeriod: {
-                                start: sampleTimePeriod.start,
-                                duration: sampleTimePeriod.durationSeconds,
+                                start: now,
+                                duration: sampleDurationSeconds,
                             },
                         },
                     };

src/sep2/models/mirrorMeterReading.ts

@@ -88,7 +88,8 @@ export function generateMirrorMeterReadingObject(
                       : undefined,
                   timePeriod: Reading.timePeriod
                       ? {
-                            duration: Reading.timePeriod.duration,
+                            // ensure integer value
+                            duration: Math.round(Reading.timePeriod.duration),
                             start: dateToStringSeconds(
                                 Reading.timePeriod.start,
                             ),