Make sure chart stores chart version in labels safely (#3205)

* Make sure chart stores chart version in labels safely

Signed-off-by: [email protected] <[email protected]>

* Revert chart vresion

---------

Signed-off-by: [email protected] <[email protected]>

Author: dee0sap

chart/templates/_helper.tpl

@@ -15,3 +15,14 @@
 {{ .repository }}:{{ .tag }}
 {{- end -}}
 {{- end -}}
+
+
+{{- define "vcluster.version.label" -}}
+{{- $rawLabel := printf "%s-%s" .Chart.Name .Chart.Version -}}
+{{- $sanitized := replace "+" "_" $rawLabel | replace "@" "_" -}}
+{{- if gt (len $sanitized) 63 -}}
+{{- $sanitized | trunc 63 -}}
+{{- else -}}
+{{- $sanitized -}}
+{{- end -}}
+{{- end -}}

chart/templates/clusterrole.yaml

@@ -5,7 +5,7 @@ metadata:
   name: {{ template "vcluster.clusterRoleName" . }}
   labels:
     app: vcluster
-    chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"
+    chart: "{{ include "vcluster.version.label"  $ }}"
     release: "{{ .Release.Name }}"
     heritage: "{{ .Release.Service }}"
   {{- if .Values.controlPlane.advanced.globalMetadata.annotations }}

chart/templates/clusterrolebinding.yaml

@@ -5,7 +5,7 @@ metadata:
   name: {{ template "vcluster.clusterRoleName" . }}
   labels:
     app: vcluster
-    chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"
+    chart: "{{ include "vcluster.version.label"  $ }}"
     release: "{{ .Release.Name }}"
     heritage: "{{ .Release.Service }}"
   {{- if .Values.controlPlane.advanced.globalMetadata.annotations }}

chart/templates/config-secret.yaml

@@ -5,7 +5,7 @@ metadata:
   namespace: {{ .Release.Namespace }}
   labels:
     app: vcluster
-    chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"
+    chart: "{{ include "vcluster.version.label"  $ }}"
     release: "{{ .Release.Name }}"
     heritage: "{{ .Release.Service }}"
   {{- if .Values.controlPlane.advanced.globalMetadata.annotations }}

chart/templates/etcd-headless-service.yaml

@@ -6,7 +6,7 @@ metadata:
   namespace: {{ .Release.Namespace }}
   labels:
     app: vcluster-etcd
-    chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"
+    chart: "{{ include "vcluster.version.label"  $ }}"
     release: "{{ .Release.Name }}"
     heritage: "{{ .Release.Service }}"
   {{- $annotations := merge dict .Values.controlPlane.advanced.globalMetadata.annotations .Values.controlPlane.backingStore.etcd.deploy.headlessService.annotations }}

chart/templates/etcd-service.yaml

@@ -7,7 +7,7 @@ metadata:
   namespace: {{ .Release.Namespace }}
   labels:
     app: vcluster-etcd
-    chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"
+    chart: "{{ include "vcluster.version.label"  $ }}"
     release: "{{ .Release.Name }}"
     heritage: "{{ .Release.Service }}"
   {{- $annotations := merge dict .Values.controlPlane.advanced.globalMetadata.annotations .Values.controlPlane.backingStore.etcd.deploy.service.annotations }}

chart/templates/etcd-statefulset.yaml

@@ -8,7 +8,7 @@ metadata:
   namespace: {{ .Release.Namespace }}
   labels:
     app: vcluster-etcd
-    chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"
+    chart: "{{ include "vcluster.version.label"  $ }}"
     release: "{{ .Release.Name }}"
     heritage: "{{ .Release.Service }}"
 {{- if $externalEtcd.labels }}

chart/templates/headless-service.yaml

@@ -6,7 +6,7 @@ metadata:
   namespace: {{ .Release.Namespace }}
   labels:
     app: vcluster
-    chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"
+    chart: "{{ include "vcluster.version.label"  $ }}"
     release: "{{ .Release.Name }}"
     heritage: "{{ .Release.Service }}"
   {{- if .Values.controlPlane.advanced.headlessService.labels }}

chart/templates/ingress.yaml

@@ -11,7 +11,7 @@ metadata:
   namespace: {{ .Release.Namespace }}
   labels:
     app: vcluster
-    chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"
+    chart: "{{ include "vcluster.version.label"  $ }}"
     release: "{{ .Release.Name }}"
     heritage: "{{ .Release.Service }}"
   {{- if .Values.controlPlane.ingress.labels }}

chart/templates/limitrange.yaml

@@ -11,7 +11,7 @@ metadata:
   {{- end }}
   labels:
     app: vcluster
-    chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"
+    chart: "{{ include "vcluster.version.label"  $ }}"
     release: "{{ .Release.Name }}"
     heritage: "{{ .Release.Service }}"
     {{- if .Values.policies.limitRange.labels }}