You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix(release): push TypeScript tag in RC builds (#25)
## Summary
Fixes a bug where the TypeScript client tag was created but never pushed
during RC builds, causing the final release workflow to fail with "Tag
vX.Y.ZrcN does not exist for stack-client-typescript".
## Root Cause
In `upload-packages-and-tag/main.sh`:
- Tags are created for all repos (including TypeScript) at line 107
- The lockfile update loop skips TypeScript with `continue` (line 131)
- Tag push happens **inside** that lockfile loop (line 161)
- Result: TypeScript tag never gets pushed
## Fix
Split the logic so TypeScript tags are pushed immediately after
creation, before the lockfile update loop runs for Python repos.
## Test Plan
- [x] Manually created and pushed the missing `v0.3.1rc5` tag for
TypeScript client
- [x] Re-ran the failed release workflow (run #18987010208)
- [ ] Next RC build will verify the fix works end-to-end
0 commit comments