Skip to content

Commit e811df8

Browse files
authored
Merge pull request #183 from evs-xsarus/feature/php84-compat
PHP 8.4 has deprecated warnings
2 parents a1864ba + 6a988b4 commit e811df8

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/Liip/RMT/Application.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ public function __construct()
7272
/**
7373
* {@inheritdoc}
7474
*/
75-
public function run(InputInterface $input = null, OutputInterface $output = null): int
75+
public function run(?InputInterface $input = null, ?OutputInterface $output = null): int
7676
{
7777
return parent::run($input, new Output());
7878
}

src/Liip/RMT/Output/Output.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ class Output extends ConsoleOutput
3636
/** @var DialogHelper|QuestionHelper */
3737
protected $dialogHelper = null;
3838

39-
public function __construct($verbosity = self::VERBOSITY_NORMAL, $decorated = null, OutputFormatterInterface $formatter = null)
39+
public function __construct($verbosity = self::VERBOSITY_NORMAL, $decorated = null, ?OutputFormatterInterface $formatter = null)
4040
{
4141
// Use our own formatter
4242
parent::__construct($verbosity, $decorated, $formatter);
@@ -115,7 +115,7 @@ public function writeEmptyLine($repeat = 1)
115115

116116
// when we drop symfony 2.3 support, we should switch to the new QuestionHelper (since 2.5) and see if we need these methods at all anymore
117117
// QuestionHelper does about the same as we do here.
118-
public function askQuestion(InteractiveQuestion $question, $position = null, InputInterface $input = null)
118+
public function askQuestion(InteractiveQuestion $question, $position = null, ?InputInterface $input = null)
119119
{
120120
$text = ($position !== null ? $position .') ' : null) . $question->getFormatedText();
121121

@@ -145,7 +145,7 @@ public function askQuestion(InteractiveQuestion $question, $position = null, Inp
145145
}
146146

147147
// when we drop symfony 2.3 support, we should switch to the QuestionHelper (since 2.5) and drop this method as it adds no value
148-
public function askConfirmation($text, InputInterface $input = null)
148+
public function askConfirmation($text, ?InputInterface $input = null)
149149
{
150150
if ($this->dialogHelper instanceof QuestionHelper) {
151151
if (!$input) {

0 commit comments

Comments
 (0)