From 4b3396799ea2220baed0392db0d94ba797a15098 Mon Sep 17 00:00:00 2001 From: onmete Date: Wed, 23 Jul 2025 15:41:22 +0200 Subject: [PATCH] Use patches to not modify global config value in test_feedback --- tests/unit/app/endpoints/test_feedback.py | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/tests/unit/app/endpoints/test_feedback.py b/tests/unit/app/endpoints/test_feedback.py index 1e2e5df2..0b7b46b7 100644 --- a/tests/unit/app/endpoints/test_feedback.py +++ b/tests/unit/app/endpoints/test_feedback.py @@ -1,5 +1,7 @@ """Unit tests for the /feedback REST API endpoint.""" +from unittest.mock import patch + from fastapi import HTTPException, status import pytest @@ -15,14 +17,20 @@ def test_is_feedback_enabled(): """Test that is_feedback_enabled returns True when feedback is not disabled.""" - configuration.user_data_collection_configuration.feedback_enabled = True - assert is_feedback_enabled() is True, "Feedback should be enabled" + with patch( + "app.endpoints.feedback.configuration.user_data_collection_configuration.feedback_enabled", + True, + ): + assert is_feedback_enabled() is True, "Feedback should be enabled" def test_is_feedback_disabled(): """Test that is_feedback_enabled returns False when feedback is disabled.""" - configuration.user_data_collection_configuration.feedback_enabled = False - assert is_feedback_enabled() is False, "Feedback should be disabled" + with patch( + "app.endpoints.feedback.configuration.user_data_collection_configuration.feedback_enabled", + False, + ): + assert is_feedback_enabled() is False, "Feedback should be disabled" async def test_assert_feedback_enabled_disabled(mocker):