Skip to content

Commit fb193c5

Browse files
authored
Merge pull request #288 from tisnik/lcore-381-new-test-minor-refactoring
LCORE-381: new unit test + minor refactoring
2 parents 4bbda24 + 5d65656 commit fb193c5

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

src/models/requests.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -267,9 +267,6 @@ def validate_categories(
267267
if value is None:
268268
return value
269269

270-
if not isinstance(value, list):
271-
raise ValueError("Categories must be a list")
272-
273270
if len(value) == 0:
274271
return None # Convert empty list to None for consistency
275272

tests/unit/models/test_requests.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,16 @@ def test_get_documents(self) -> None:
122122
assert documents[1]["content"] == "kind: Pod\n metadata:\n name: private-reg"
123123
assert documents[1]["mime_type"] == "application/yaml"
124124

125+
def test_get_documents_no_attachments(self) -> None:
126+
"""Test the get_documents method."""
127+
attachments = []
128+
qr = QueryRequest(
129+
query="Tell me about Kubernetes",
130+
attachments=attachments,
131+
)
132+
documents = qr.get_documents()
133+
assert len(documents) == 0
134+
125135
def test_validate_provider_and_model(self) -> None:
126136
"""Test the validate_provider_and_model method."""
127137
qr = QueryRequest(

0 commit comments

Comments
 (0)