LSPS5 Follow ups #3944
Description
PR #3662 got too big, so a few small fixes will come in follow up PRs once the base PR is merged
Fixes coming in a follow up:
With PR:
- avoid timestamp validation on validator LSPS5 implementation #3662 (comment) Simplify LSPS5/validator: drop time checks & custom signature storage #3961
- drop signature config, only have a few signatures for the replay attack check LSPS5 implementation #3662 (comment) Simplify LSPS5/validator: drop time checks & custom signature storage #3961
- Move time_provider trait into crate::utils::time or similar LSPS5 implementation #3662 (comment) LSPS5 follow up: Move TimeProvider to utils::time module for better organization #3962
- drop unnecesary time_provider.clone() in manager LSPS5 implementation #3662 (comment) LSPS5 - small follow ups #3963
- do not duplicate DEFAULT_RESPONSE_MAX_AGE_SECS LSPS5 implementation #3662 (comment) LSPS5 - small follow ups #3963
- rename broadcast_notification in service (LSPS5 implementation #3662 (comment)) LSPS5 - small follow ups #3963
Without PR:
- fix incorrect log::info / log::error (could be a peer sending us garbage) on lsps5 client LSPS5 implementation #3662 (comment) / LSPS5 implementation #3662 (comment)
- fix notification_cooldown_hours on lsps5 service LSPS5 implementation #3662 (comment)
- copy LSPSDateTime instead of cloning LSPS5 implementation #3662 (comment)
- docs wrong and return Duration instead of u64 on abs_diff LSPS5 implementation #3662 (comment)
- clean up the overall PeerState once it's empty LSPS5 implementation #3662 (comment)
- drop TimeProvider from LSPS5ClientHandler, only keep X pending requests LSPS5 implementation #3662 (comment)
- LSPS5 DOS protection