PWX-33934: remove tight loop around volumeBackup status check

- Removed the frequent BackupId check while a volume backup is in progress
  It is being called in a tight for-loop, now it is called every reconciler
  sync interval.

Signed-off-by: Lalatendu Das <[email protected]>

Author: lalat-das

pkg/applicationmanager/controllers/applicationbackup.go

@@ -660,7 +660,6 @@ func (a *ApplicationBackupController) backupVolumes(backup *stork_api.Applicatio
 		namespacedName.Namespace = backup.Namespace
 		namespacedName.Name = backup.Name
 		if len(backup.Status.Volumes) != pvcCount {
-
 			for driverName, pvcs := range pvcMappings {
 				var driver volume.Driver
 				driver, err = volume.Get(driverName)
@@ -726,44 +725,31 @@ func (a *ApplicationBackupController) backupVolumes(backup *stork_api.Applicatio
 					if err != nil {
 						return err
 					}
-					// In case Portworx if the snapshot ID is populated for every volume then the snapshot
-					// process is considered to be completed successfully.
-					// This ensures we don't execute the post-exec before all volume's snapshot is completed
-					if driverName == volume.PortworxDriverName {
-						startTime := time.Now()
-						for {
-							// In case below logic genuinely takes long time for many volumes
-							// the CR timestamp need to be updated. This prevents backup timeout error.
-							elapsedTime := time.Since(startTime)
-							if elapsedTime > utils.TimeoutUpdateBackupCrTimestamp {
-								backup, err = a.updateBackupCRInVolumeStage(
-									namespacedName,
-									stork_api.ApplicationBackupStatusInProgress,
-									backup.Status.Stage,
-									"Volume backups are in progress",
-									volumeInfos,
-								)
-								if err != nil {
-									return err
-								}
-								startTime = time.Now()
-							}
-							// Get fresh stock of the status for all volumes.
-							snapshotNotCompleted := false
-							volumeInfos, err = driver.GetBackupStatus(backup)
-							if err != nil {
-								log.ApplicationBackupLog(backup).Errorf("error getting backup status for driver %v: %v", driverName, err)
-								return fmt.Errorf("error getting backup status for driver %v: %v", driverName, err)
-							}
-							for _, volInfo := range volumeInfos {
-								if volInfo.BackupID == "" {
-									log.ApplicationBackupLog(backup).Tracef("Snapshot of volume %v is not done yet, need to loop till snapshot is done...", volInfo.PersistentVolumeClaim)
-									snapshotNotCompleted = true
-								}
-							}
-							if !snapshotNotCompleted {
-								break
-							}
+				}
+			}
+
+			// In case Portworx if the snapshot ID is populated for every volume then the snapshot
+			// process is considered to be completed successfully.
+			// This ensures we don't execute the post-exec before all volume's snapshot is completed
+			for driverName := range pvcMappings {
+				var driver volume.Driver
+				driver, err = volume.Get(driverName)
+				if err != nil {
+					return err
+				}
+				if driverName == volume.PortworxDriverName {
+					volumeInfos, err := driver.GetBackupStatus(backup)
+					if err != nil {
+						return fmt.Errorf("error getting backup status: %v", err)
+					}
+					for _, volInfo := range volumeInfos {
+						if volInfo.BackupID == "" {
+							log.ApplicationBackupLog(backup).Infof("Snapshot of volume [%v] hasn't completed yet, retry checking status", volInfo.PersistentVolumeClaim)
+							// Some portworx volume snapshot is not completed yet
+							// hence we will retry checking the status in the next reconciler iteration
+							// *stork_api.ApplicationBackupVolumeInfo.Status is not being checked here
+							// since backpID confirms if the snapshot is done or not already
+							return nil
 						}
 					}
 				}