Increase 'seen' db field length (#27), add js source maps

Author: zpottie

CHANGELOG.md

@@ -1,5 +1,15 @@
 # Changelog
 
+## v1.4.1 - 06/01/2021
+
+### Added
+* JS source maps.
+
+### Changed
+* Increased 'precision'/length of `seen` field in database (from 4 to 10).
+* Minor Moodle code-check fixes.
+* Bumped version number.
+
 ## v1.4.0 - 18/12/2020
 
 ### Added

amd/build/custom.min.js

@@ -1,4 +1,4 @@
-/* eslint no-console: ["error", { allow: ["error"] }] */
+/* eslint no-console: ["error", { allow: ["error"] }], max-nested-callbacks: ["error", 7] */
 /**
  * @package    block_advnotifications
  * @copyright  2019 onwards LearningWorks Ltd {@link https://learningworks.co.nz/}

amd/build/custom.min.js.map

@@ -1,4 +1,4 @@
-/* eslint no-console: ["error", { allow: ["error"] }] */
+/* eslint no-console: ["error", { allow: ["error"] }], max-nested-callbacks: ["error", 7] */
 /**
  * @package    block_advnotifications
  * @copyright  2019 onwards LearningWorks Ltd {@link https://learningworks.co.nz/}

amd/build/notif.min.js

@@ -30,7 +30,7 @@
         <FIELD NAME="user_id" TYPE="int" LENGTH="20" NOTNULL="true" SEQUENCE="false" COMMENT="User related to occurrence of notification"/>
         <FIELD NAME="not_id" TYPE="int" LENGTH="20" NOTNULL="true" SEQUENCE="false" COMMENT="Notification user interaction relates to"/>
         <FIELD NAME="dismissed" TYPE="int" LENGTH="1" NOTNULL="true" SEQUENCE="false" COMMENT="Flag of whether user dismissed occurrence of notification or not"/>
-        <FIELD NAME="seen" TYPE="int" LENGTH="4" NOTNULL="true" DEFAULT="0" SEQUENCE="false" COMMENT="Record of number of times a user has seen the notification"/>
+        <FIELD NAME="seen" TYPE="int" LENGTH="10" NOTNULL="true" DEFAULT="0" SEQUENCE="false" COMMENT="Record of number of times a user has seen the notification"/>
       </FIELDS>
       <KEYS>
         <KEY NAME="primary" TYPE="primary" FIELDS="id"/>

amd/build/notif.min.js.map

@@ -25,18 +25,18 @@
 
 defined('MOODLE_INTERNAL') || die;
 
-
 /**
  * When upgrading plugin, execute the following code.
  *
- * @param int $oldversion - previous version of plugin (from DB).
+ * @param int $oldversion Previous version of plugin (from DB).
+ * @return bool Successful upgrade or not.
  */
 function xmldb_block_advnotifications_upgrade($oldversion) {
     global $DB;
     $dbman = $DB->get_manager();
 
+    // This was needed to add tables during development - probably not even need anymore. Leaving just-in-case (for now).
     if ($oldversion < 2017100217) {
-
         // Define table block_advnotifications to be created.
         $table = new xmldb_table('block_advnotifications');
 
@@ -88,6 +88,20 @@ function xmldb_block_advnotifications_upgrade($oldversion) {
         upgrade_block_savepoint(true, 2017100217, 'advnotifications');
     }
 
+    // If upgrading from version earlier than v1.4.1 - max for 'seen' needs to be increased.
+    if ($oldversion < 2021010616) {
+
+        // Increase length/precision of field 'seen' in table 'block_advnotificationsdissed' to '10'.
+        $table = new xmldb_table('block_advnotificationsdissed');
+        $field = new xmldb_field('seen', XMLDB_TYPE_INTEGER, '10', null, XMLDB_NOTNULL, null, '0');
+
+        // Update DB.
+        $dbman->change_field_precision($table, $field);
+
+        // Upgrade savepoint reached.
+        upgrade_block_savepoint(true, 2021010616, 'advnotifications');
+    }
+
     // Add future upgrade points here.
 
     return true;