Skip to content

refactor: Migrate to Typescript #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 199 commits into
base: main
Choose a base branch
from
Open

refactor: Migrate to Typescript #65

wants to merge 199 commits into from

Conversation

@yell0wsuit
Copy link
Collaborator

@yell0wsuit yell0wsuit commented May 31, 2025 •
edited
Loading

Closes #56

Refactor

  • Use Zod schemas for validating data instead of directly manipulating localstorage data.
  • Added new TypeScript declaration files for structured data types across conversation, exam, exercise, sound, and word pages.
  • Migrated frontend and Electron codebase from JavaScript/PropTypes to TypeScript with explicit type annotations.
  • Updated Electron build, artifact, and deployment workflows for improved packaging and directory structure.
  • Modernized ESLint and Electron Forge configurations to support TypeScript and new directory conventions.
  • Refined and consolidated component props, state, and event handler typings for clarity and maintainability.

Bug fixes

  • Improved error handling and type safety throughout the app, especially in Electron IPC, file operations, and localStorage access.
  • Fixed accessibility issues by adding alt/title attributes and improving button semantics.
  • Enhanced localStorage parsing to prevent runtime errors from malformed data.

Chores

  • Updated and expanded development scripts, dependencies, and dev tools in package configuration.
  • Improved and reorganized documentation for local development, coding style, and contribution guidelines.
  • Added and updated .gitignore entries for new build directories and artifacts.
  • Removed legacy and unused files, including old preload scripts, data JSONs, and deprecated components.

yell0wsuit added 30 commits May 27, 2025 12:39
@yell0wsuit
convert to ts part 1
c1821f1
@yell0wsuit
fix eslint error
f7e3907
@yell0wsuit
convert to ts part 2
b595cbd
@yell0wsuit
convert to ts part 3
06f898a
@yell0wsuit
convert to ts part 4
5464233
@yell0wsuit
convert to ts part 5
a9f4142
@yell0wsuit
convert to ts part 6
268fc49
@yell0wsuit
convert to ts part 7
78d07ed
@yell0wsuit
convert to ts part 8
4715723
@yell0wsuit
convert to ts part 9
2f67a95
@yell0wsuit
convert to ts part 10
095a834
@yell0wsuit
convert to ts part 11
8e5590e
@yell0wsuit
Create tsconfig.json
0e72c31
@yell0wsuit
convert to ts part 12
3447f50
@yell0wsuit
convert to ts part 13
7c511c2
@yell0wsuit
convert to ts part 14
da2ee65
@yell0wsuit
update express server code
e1a22b1
@yell0wsuit
convert forge config to ts
be58b27
@yell0wsuit
fix lint error right in tsconfig lol
51e84df
@yell0wsuit
format eslint config file
9f1ab04
@yell0wsuit
fix lint errors
d529eca
@yell0wsuit
Update tsconfig.json
a91d6f5
@yell0wsuit
Update eslint.config.js
a1ade74
@yell0wsuit
update videoFileOperation to conform eslint rule
473bfff
@yell0wsuit
update pronunciationOperations to conform eslint rule
983fd18
@yell0wsuit
update main.ts to conform eslint rule
22aa33a
@yell0wsuit
update zipOperation to conform eslint rule
c732026
@yell0wsuit
Update createWindow.ts
a5cf2c7
@yell0wsuit
Update customFolderLocationOperation.ts
4bb9fd8
@yell0wsuit
add ts dependencies
155441e
yell0wsuit added 23 commits June 1, 2025 21:22
@yell0wsuit
remove leftover makecli command
c3ed7f5
@yell0wsuit
update electron workflow
ee4c4a2
@yell0wsuit
disable source map output
9438dc8
@yell0wsuit
fix video download modal overflow and progress bar
6f98385
@yell0wsuit
minify electron js files
59b77d0
@yell0wsuit
sound page: modular and update types
a89e573
@yell0wsuit
conversation page: modularize and update types
b59fd8a
@yell0wsuit
sound page: unify types
02602bb
@yell0wsuit
conversation page: unify types
cf52bd2
@yell0wsuit
conversation page: fix types, beautify the iframe title
5eafd86
@yell0wsuit
exam page: modularize and update types
08f4583
@yell0wsuit
exercise page: modularize and update types
7e5bc28
@yell0wsuit
sound page: add string type for toast for ReviewCard
dca2ae1
@yell0wsuit
Update eslint.config.js
d19752c
@yell0wsuit
update tsconfig
15a5e4c
@yell0wsuit
update packages, add zod
afc1aa0
@yell0wsuit
update timer setting code
9d7d75b
@yell0wsuit
Improve timer toggle to handle unsaved changes
ee99744 
When disabling the timer, tempSettings are now reverted to the last saved values, discarding any unsaved changes
@yell0wsuit
use zod for validating accent local storage
503c5c5
@yell0wsuit
Update types.ts
c2410f9
@yell0wsuit
Fix accent prop usage in ExamDetailPage
3c7cef5
@yell0wsuit
Add zod validation for localstorage in ReviewTab
0267bd3
@yell0wsuit
add zod validation to ReviewTab localstorage handling
a2861f3
@coderabbitai

This comment was marked as outdated.

Sign in to view
coderabbitai bot added a commit that referenced this pull request Jun 23, 2025
@coderabbitai
📝 Add docstrings to typescript
aa7400a 
Docstrings generation was requested by @yell0wsuit.

* #65 (comment)

The following files were modified:

* `src/frontend/components/setting_page/LogSettings.tsx`
* `src/frontend/components/setting_page/PronunciationSettings.tsx`
@coderabbitai coderabbitai bot mentioned this pull request Jun 23, 2025
Closed
@coderabbitai

This comment was marked as outdated.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate codebase to TypeScript

2 participants

@yell0wsuit