Skip to content

chore: rename String.Pos to String.Pos.Raw #10624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 1, 2025
Merged

chore: rename String.Pos to String.Pos.Raw #10624

merged 6 commits into from
Oct 1, 2025

Conversation

@TwoFX
Copy link
Member

@TwoFX TwoFX commented Sep 30, 2025

This PR renames String.Pos to String.Pos.Raw.

After an abbreviated deprecation cycle, we will then rename String.ValidPos to String.Pos.

@TwoFX TwoFX added changelog-library Library WIP This is work in progress, and only a PR for the sake of CI or sharing. No review yet. labels Sep 30, 2025
@TwoFX TwoFX changed the title chore: rename String.Pos to String.Pow.Raw chore: rename String.Pos to String.Pos.Raw Sep 30, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Sep 30, 2025
@leanprover-bot
Copy link
Collaborator

Reference manual CI status:

  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2025-09-30 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2025-09-30 14:55:06)

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Sep 30, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#10624
0f4e5cd
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Sep 30, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#10624
2dafcfc
@leanprover-community-bot leanprover-community-bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Sep 30, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Sep 30, 2025 •
edited
Loading

Mathlib CI status (docs):

@TwoFX TwoFX removed the WIP This is work in progress, and only a PR for the sake of CI or sharing. No review yet. label Oct 1, 2025
@TwoFX TwoFX marked this pull request as ready for review October 1, 2025 07:37
@TwoFX TwoFX enabled auto-merge October 1, 2025 07:37
@TwoFX TwoFX added this pull request to the merge queue Oct 1, 2025
Merged via the queue into leanprover:master with commit 81ea922 Oct 1, 2025
17 of 18 checks passed
arthur-adjedj pushed a commit to arthur-adjedj/lean4 that referenced this pull request Oct 6, 2025
@TwoFX @arthur-adjedj
chore: rename String.Pos to String.Pos.Raw (leanprover#10624)
158afca 
This PR renames `String.Pos` to `String.Pos.Raw`.

After an abbreviated deprecation cycle, we will then rename
`String.ValidPos` to `String.Pos`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@digama0 digama0 Awaiting requested review from digama0 digama0 is a code owner

@kim-em kim-em Awaiting requested review from kim-em kim-em is a code owner

@mhuisi mhuisi Awaiting requested review from mhuisi mhuisi is a code owner

@kmill kmill Awaiting requested review from kmill kmill is a code owner

@Kha Kha Awaiting requested review from Kha Kha is a code owner

@tydeu tydeu Awaiting requested review from tydeu tydeu is a code owner

Assignees

No one assigned

Labels

breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TwoFX @leanprover-bot @leanprover-community-bot