Skip to content

Inconsistent Prop Naming in SectionTitle and Button Components #6291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 tasks
falgunmpatel opened this issue Mar 8, 2025 · 4 comments
Open
2 tasks

Inconsistent Prop Naming in SectionTitle and Button Components #6291

falgunmpatel opened this issue Mar 8, 2025 · 4 comments
Labels
kind/bug Something isn't working

Comments

@falgunmpatel
Copy link
Contributor

falgunmpatel commented Mar 8, 2025

Description

There is inconsistency in prop naming conventions across the codebase:

  • $UniWidth is defined in the SectionTitle component, but UniWidth is used in several places instead of @$UniWidth.
  • $secondary is defined in the Button component, but many implementations use secondary instead.

Expected Behavior

  • Ensure that $UniWidth is used consistently as @$UniWidth.
  • Ensure that $secondary is used instead of secondary for consistency.

Tasks

  • Replace UniWidth with @$UniWidth where necessary.
  • Replace secondary with $secondary in relevant implementations.

Screenshots

Image Image

Environment:

  • Host OS:
  • Browser:

Contributor Resources and Handbook

The layer5.io website uses Gatsby, React, and GitHub Pages. Site content is found under the master branch.

Join the Layer5 Community by submitting your community member form.

@falgunmpatel falgunmpatel added the kind/bug Something isn't working label Mar 8, 2025
@tanishq3105
Copy link

@falgunmpatel i would like to resolve this issue

@falgunmpatel
Copy link
Contributor Author

Hi @tanishq3105
Thanks for your interest in taking up this issue! Before assigning it, we need clarification on whether the incorrectly used props should be removed or renamed with a $ prefix, as renaming could impact the UI.

Once we get confirmation from the maintainers, I'll update you. Appreciate your patience!

@heysubinoy
Copy link

Hey @falgunmpatel any updates on this, would like to work on it if it's decided

@Souradip121
Copy link
Contributor

The issue is still there. can I be assigned to this? @vishalvivekm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Development

No branches or pull requests

4 participants