Skip to content

Eliminate go_high, go_low syntax #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
philipstarkey opened this issue May 31, 2017 · 0 comments
Open

Eliminate go_high, go_low syntax #37

philipstarkey opened this issue May 31, 2017 · 0 comments
Labels
enhancement New feature or request minor

Comments

@philipstarkey
Copy link
Member

Original report (archived issue) by Ian B. Spielman (Bitbucket: Ian Spielman, GitHub: ispielma).

For no apparent reason digital lines behave different from analog lines. For example I propose instead:

do_line.go_high(t)
becomes:
do_line.constant(t, 1) or
do_line.constant(t, True)

this allows uniform syntax across analog and digital lines, and makes programming do lines with variables more natural. Realistically the go_high/low methods would remain, but be depreciated.
@philipstarkey philipstarkey added minor enhancement New feature or request labels Apr 5, 2020
Loki27182 pushed a commit to Loki27182/labscript that referenced this issue Oct 9, 2023
@chrisjbillington
Merged in cbillington/labscript/transition_order (pull request labscr…
56fde5d 
…ipt-suite#37)

start_order and stop_order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request minor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@philipstarkey