Skip to content

Commit bd82a28

Browse files
authored
Disallow using Docker Desktop 4.34.0 on macos (#19576)
* Disallow using Docker Desktop 4.34.0 on macos * Disallow using Docker Desktop 4.34.0 on macos * remove unneeded changes * remove unneeded changes * update changelog
1 parent fe41066 commit bd82a28

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
Breaking Changes:
66
* Bump minimum podman version to 4.9.0 [#19457](https://github.com/kubernetes/minikube/pull/19457)
7-
7+
* Disallow using Docker Desktop 4.34.0
88
Features:
99
* Bump default Kubernetes version to v1.31.0 [#19435](https://github.com/kubernetes/minikube/pull/19435)
1010
* Add new driver for macOS: vfkit [#19423](https://github.com/kubernetes/minikube/pull/19423)

pkg/minikube/registry/drvs/docker/docker.go

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -289,6 +289,17 @@ func checkDockerDesktopVersion(version string) (s registry.State) {
289289
Fix: "Update Docker Desktop to 4.16.1 or greater",
290290
}
291291
}
292+
293+
if runtime.GOOS == "darwin" && currSemver.EQ(semver.MustParse("4.34.0")) {
294+
return registry.State{
295+
Reason: "PROVIDER_DOCKER_DESKTOP_VERSION_BAD",
296+
Running: true,
297+
Error: errors.New("Docker Desktop 4.34.0 has a regression that prevents minikube from listing the containers"),
298+
Installed: true,
299+
Fix: "Use a different Docker desktop version, more info at https://github.com/docker/cli/issues/5412",
300+
}
301+
}
302+
292303
return s
293304
}
294305

0 commit comments

Comments
 (0)