Add mesh conformance tests for httproute port and scheme redirect #3776
+344
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
cncf-cla: yes
LiorLieberman
force-pushed
the
httproute-redirect-mesh-tests
branch
from
2c64c87 to
a88271b
Compare
|
/retest |
|
/cc @kflynn |
robscott
approved these changes
May 14, 2025
| MeshConformanceTests = append(MeshConformanceTests, MeshHTTPRouteRedirectPort) | ||
| } | ||
|
|
||
| var MeshHTTPRouteRedirectPort = suite.ConformanceTest{ |
There was a problem hiding this comment.
I think I missed this from the earlier conversations, but what's the plan to make these tests more sustainable + maintainable? Would it be viable to just have a simple script that did the copying and modification required for any tests that should be replicated for mesh? Is there a way to share the same test definitions for both?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LiorLieberman, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/area conformance-test
Add mesh tests for port and scheme redirect
This is a follow up to #3729
What this PR does / why we need it:
Add mesh tests coverage
Which issue(s) this PR fixes:
Related #3581
Does this PR introduce a user-facing change?: