Skip to content

Merge two metrics http server #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nayihz opened this issue Apr 16, 2025 · 4 comments · May be fixed by #728
Open

Merge two metrics http server #699

nayihz opened this issue Apr 16, 2025 · 4 comments · May be fixed by #728
Assignees
@nayihz
Labels
triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@nayihz
Copy link
Contributor

nayihz commented Apr 16, 2025

What would you like to be added:
Now we have two http listener to serve /metrics. One is controller-manager's default metric server, listening on port 8080. The other one is the metric server that we implemented ourselves which is listening on port 9090.

gateway-api-inference-extension/cmd/epp/main.go

Line 243 in f7faddc

func registerMetricsHandler(mgr manager.Manager, port int, cfg *rest.Config) error {

Why is this needed:
We don't need two metric servers in one controller.
@nayihz
Copy link
Contributor Author

nayihz commented Apr 16, 2025

I'd like to work on it if mantainers aggree to do this.

@kfswain
Copy link
Collaborator

kfswain commented Apr 21, 2025

SGTM

CC: @ahg-g , @danehans if you have any opinions

@danehans
Copy link
Contributor

@nayihz is your plan to remove the separate metrics handler and use metrics from the controller-runtime manager?

@nayihz
Copy link
Contributor Author

nayihz commented Apr 23, 2025

@nayihz is your plan to remove the separate metrics handler and use metrics from the controller-runtime manager?

Yes.
/assign

@nayihz nayihz linked a pull request Apr 23, 2025 that will close this issue
Open
@kfswain kfswain added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nayihz nayihz

Labels
triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: merge two metric servers nayihz/gateway-api-inference-extension
3 participants
@danehans @nayihz @kfswain