Skip to content

Commit e4d1ca6

Browse files
committed
fix: metric reset not effect
1 parent a0c823e commit e4d1ca6

File tree

2 files changed

+16
-17
lines changed

2 files changed

+16
-17
lines changed

pkg/epp/metrics/metrics.go

+14-14
Original file line numberDiff line numberDiff line change
@@ -203,20 +203,20 @@ func Register() {
203203
}
204204

205205
// Just for integration test
206-
func Unregister() {
207-
metrics.Registry.Unregister(requestCounter)
208-
metrics.Registry.Unregister(requestErrCounter)
209-
metrics.Registry.Unregister(requestLatencies)
210-
metrics.Registry.Unregister(requestSizes)
211-
metrics.Registry.Unregister(responseSizes)
212-
metrics.Registry.Unregister(inputTokens)
213-
metrics.Registry.Unregister(outputTokens)
214-
metrics.Registry.Unregister(runningRequests)
215-
metrics.Registry.Unregister(NormalizedTimePerOutputToken)
216-
217-
metrics.Registry.Unregister(inferencePoolAvgKVCache)
218-
metrics.Registry.Unregister(inferencePoolAvgQueueSize)
219-
metrics.Registry.Unregister(inferencePoolReadyPods)
206+
func Reset() {
207+
requestCounter.Reset()
208+
requestErrCounter.Reset()
209+
requestLatencies.Reset()
210+
requestSizes.Reset()
211+
responseSizes.Reset()
212+
inputTokens.Reset()
213+
outputTokens.Reset()
214+
runningRequests.Reset()
215+
NormalizedTimePerOutputToken.Reset()
216+
inferencePoolAvgKVCache.Reset()
217+
inferencePoolAvgQueueSize.Reset()
218+
inferencePoolReadyPods.Reset()
219+
SchedulerPluginProcessingLatencies.Reset()
220220
}
221221

222222
// RecordRequstCounter records the number of requests.

test/integration/epp/hermetic_test.go

+2-3
Original file line numberDiff line numberDiff line change
@@ -1196,7 +1196,6 @@ func TestFullDuplexStreamed_KubeInferenceModelRequest(t *testing.T) {
11961196

11971197
for _, test := range tests {
11981198
t.Run(test.name, func(t *testing.T) {
1199-
metrics.Register()
12001199
client, cleanup := setUpHermeticServer(t, test.pods, true)
12011200
t.Cleanup(cleanup)
12021201
responses, err := integrationutils.StreamedRequest(t, client, test.requests, len(test.wantResponses))
@@ -1215,9 +1214,8 @@ func TestFullDuplexStreamed_KubeInferenceModelRequest(t *testing.T) {
12151214
}
12161215
}
12171216
}
1218-
metrics.Unregister()
1217+
metrics.Reset()
12191218
})
1220-
return
12211219
}
12221220
}
12231221

@@ -1331,6 +1329,7 @@ func BeforeSuite() func() {
13311329
// Init runtime.
13321330
ctrl.SetLogger(logger)
13331331

1332+
metrics.Register()
13341333
// Register metrics handler.
13351334
// Metrics endpoint is enabled in 'config/default/kustomization.yaml'. The Metrics options configure the server.
13361335
// More info:

0 commit comments

Comments
 (0)