Skip to content

Commit 4bf03ad

Browse files
shaneuttk8s-ci-robot
authored andcommitted
fix: check for distinct gRPC services in bbr health check
Signed-off-by: Shane Utt <[email protected]>
1 parent a6c3ede commit 4bf03ad

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

cmd/bbr/health.go

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ package main
1919
import (
2020
"context"
2121

22+
extProcPb "github.com/envoyproxy/go-control-plane/envoy/service/ext_proc/v3"
2223
"github.com/go-logr/logr"
2324
"google.golang.org/grpc/codes"
2425
healthPb "google.golang.org/grpc/health/grpc_health_v1"
@@ -31,7 +32,12 @@ type healthServer struct {
3132
}
3233

3334
func (s *healthServer) Check(ctx context.Context, in *healthPb.HealthCheckRequest) (*healthPb.HealthCheckResponse, error) {
34-
s.logger.V(logutil.VERBOSE).Info("gRPC health check serving", "service", in.Service)
35+
if in.Service != extProcPb.ExternalProcessor_ServiceDesc.ServiceName {
36+
s.logger.V(logutil.DEFAULT).Info("gRPC health check requested unknown service", "available-services", []string{extProcPb.ExternalProcessor_ServiceDesc.ServiceName}, "requested-service", in.Service)
37+
return &healthPb.HealthCheckResponse{Status: healthPb.HealthCheckResponse_SERVICE_UNKNOWN}, nil
38+
}
39+
40+
s.logger.V(logutil.VERBOSE).Info("gRPC health check serving", "service", extProcPb.ExternalProcessor_ServiceDesc.ServiceName)
3541
return &healthPb.HealthCheckResponse{Status: healthPb.HealthCheckResponse_SERVING}, nil
3642
}
3743

0 commit comments

Comments
 (0)