Extern/exinfinitum/device slot improvement #246
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DevicePrep to check slot IDs
…bj 'deviceSlotIDs
Device slot improvements (pulled in from exinfinitum/TranscendenceDev deviceSlotImprovements)
…provement # Conflicts: # Mammoth/Include/TSE.h # Mammoth/Include/TSEVersions.h # Transcendence/TransCore/Transcendence.xml
FlufflesTheMicrosaur
changed the base branch from
master
to
integration/API58
Collaborator
|
After discussion, we have decided to reimplement this in pieces using the newer design patterns and feature-by-feature to avoid an overly large PR that is hard to review, and to ensure the expected behavior needed for 2.0. Leaving it open as a draft for now to use as a reference in case its handy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an updated copy of: #75
Currently the update process is in-progress