Make it possilbe to turn off the usage of signs

* Since it seems the vim command "sign place" is sometimes slow make it
  possible to disable the usage of signs completely. Diagnostics will
  still be processed and possible to display by using the lspDiagnostics
  command.
* Update travis du use create_release.py --dev

Author: kristopher-h

.travis.yml

@@ -2,7 +2,7 @@ language: python
 python:
     - "3.6"
 install:
-    - tools/create_portable_pyls.py
+    - tools/create_release.py --dev
     - pip install tox
 script:
     - cd plugin; tox

DEVELOPMENT.rst

@@ -27,14 +27,15 @@ Testing of the pythoncode is done with tox. So first make sure you have tox inst
 
     pip install tox
 
+Optional: To install the supported language servers in the repo run::
+
+    tools/create_release --dev
+
 Once tox is installed simply run tox from the plugin folder of vim-liq::
 
     cd ~/path/to/vim-liq-repo/plugin
     tox
 
-This will run unittests and linting (currently flake8 is used for linting). As a part of testing
-the lsp servers supported will be downloaded/installed locally in plugin/tests/.lsp_install_dir.
-This is however only done the first time the test is run. To force a re-install one must manually
-remove the .lsp_install_dir.
+This will run unittests and linting (currently flake8 is used for linting).
 
 There currently is no tests for the vimscript code.

README.rst

@@ -79,9 +79,13 @@ To disbale the default keymap set the following in your .vimrc::
 
     let g:langIQ_disablekeymap = 1
 
-Diagnostics is automatically enabled and uses vim marks. When moving to a line with a diagnostics
+Diagnostics is automatically enabled and uses vim signs. When moving to a line with a diagnostics
 mark the message for that line is displayed in the command-line.
 
+To disable the usage of signs set the following in your .vimrc::
+
+    let g:langIQ_disablesigns = 1
+
 Additional commands:
 
 | **LspDiagnostics:** Display diagnostics in the quickfix window.

plugin/vim_liq.vim

@@ -35,6 +35,9 @@ endif
 if !exists("g:langIQ_disablekeymap")
     let g:langIQ_disablekeymap = 0
 endif
+if !exists("g:langIQ_disablesigns")
+    let g:langIQ_disablesigns = 0
+endif
 let g:vim_lsp_logdir = expand("<sfile>:h")."/log/"
 let g:vim_lsp_log_to_file = 0
 let g:vim_lsp_debug = 1

plugin/vimliq/client.py

@@ -20,6 +20,7 @@
 import logging
 import os
 import re
+import time
 
 import lsp.client
 import lsp.jsonrpc
@@ -102,14 +103,17 @@ class VimLspClient(object):
     VimLspClient also expose functions for communicating with the server.
     """
 
-    def __init__(self, start_cmd, transport):
+    def __init__(self, start_cmd, transport, use_signs=True):
         """Initialize
 
         Args:
-            supported_clients(dict): See supported_clients.json
+            start_cmd(str): Command used to start LSP server connected to this client.
+            transport(str): Currently only "STDIO" is supported.
+            use_signs(bool): If True use vim "signs".
         """
         self._start_cmd = start_cmd
         self._transport = transport
+        self._use_signs = use_signs
         self.td_version = 0
         self._sign_id = 1
         self.diagnostics = {}
@@ -131,6 +135,7 @@ def start_server(self):
         self._client.initialize(root_path=path, root_uri="file://" + path)
 
     def _next_sign_id(self):
+        log.debug("next sign %s", time.time())
         self._sign_id += 1
         file_ = V.current_file()
         all_ids = set(re.findall("id=(\d+)", V.vim_command("sign place file={}".format(file_))))
@@ -140,6 +145,7 @@ def _next_sign_id(self):
                 self._sign_id = 1
             self._sign_id += 1
 
+        log.debug("next sign %s", time.time())
         return self._sign_id
 
     @staticmethod
@@ -180,7 +186,7 @@ def process_diagnostics(self):
         for diag in self._client.diagnostics():
             local_uri = self._parse_uri(diag.uri)
             self.diagnostics[local_uri] = diag.diagnostics
-            if local_uri == cur_file:
+            if local_uri == cur_file and self._use_signs:
                 self.update_signs()
 
     def display_diagnostics(self):

plugin/vimliq/clientmanager.py

@@ -27,6 +27,7 @@
 from . import client
 from . import vimutils as V
 
+import vim
 
 log = logging.getLogger(__name__)
 log.addHandler(logging.NullHandler())
@@ -58,6 +59,7 @@ def __init__(self, supported_clients):
         Attributes:
             clients(dict): Dict where key is the language and value is the client object.
         """
+        self._use_signs = vim.eval("g:langIQ_disablesigns") == "0"
         self._supported_clients = supported_clients
         self.clients = {}
 
@@ -77,7 +79,7 @@ def add_client(self):
 
             log.debug("Starting client, start_cmd: %s, transport: %s", start_cmd, transport)
             try:
-                l_client = client.VimLspClient(start_cmd, transport)
+                l_client = client.VimLspClient(start_cmd, transport, use_signs=self._use_signs)
                 l_client.start_server()
                 log.debug("Added client for %s", ft)
                 self.clients[ft] = l_client