-
-
Notifications
You must be signed in to change notification settings - Fork 99
Open
Description
Firstly, is this a bug or feature? - code appears to be written intentionally
Describe the bug
When combobox & search (which uses combobox) blurs, the old options are shown temporarily.
There are 2 sources of truths for displayed options:
local.optionsprovided through propslastDisplayedOptionsused internally to "Prevents the popover contents from updating as the combobox closes"
But this leads to janky behaviour as the popover content closes - especially on animation.
To Reproduce
- Type something into combobox - with results
- Change input - with different results
- Click outside combobox to blur - observe
Slow down css animation to see the jank
unexpected.mp4
Expected behavior
Close without content changing:
expected.mp4
Additional context
Location of code behaviour combobox-base.tsx:
const displayedOptions = createMemo(() => {
if (disclosureState.isOpen()) {
if (showAllOptions()) {
return local.options!;
}
return filteredOptions();
}
return lastDisplayedOptions();
});Metadata
Metadata
Assignees
Labels
No labels