Skip to content

debug: add a log for injectedArgs #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from

Conversation

0xferit
Copy link
Member

@0xferit 0xferit commented Jul 14, 2025

No description provided.

@0xferit 0xferit force-pushed the refactor/evidence-display-processing branch from 85322ae to 3929853 Compare July 14, 2025 04:10
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

0xferit added 3 commits July 14, 2025 06:06
- Add issues: write permission for issue comments
- Add pull-requests: write permission for PR comments
- Add repository-projects: write permission for project access
- Set permissions at both workflow and job level
@0xferit 0xferit force-pushed the refactor/evidence-display-processing branch from cdc0862 to 3e9cfa7 Compare July 14, 2025 05:10
cursor[bot]

This comment was marked as outdated.

- Add condition to exclude cursor[bot] and all bot actors
- Prevents permission errors when bots trigger the workflow
- Keeps Claude action active for human users only
cursor[bot]

This comment was marked as outdated.

@0xferit
Copy link
Member Author

0xferit commented Jul 14, 2025

@claude

Copy link

github-actions bot commented Jul 14, 2025

Claude encountered an error —— View job

Failed with exit code 128

I'll analyze this and get back to you.

- Add actions/checkout@v4 with full git history (fetch-depth: 0)
- Switch from API key + GitHub token to OAuth token approach
- Remove bot filtering since OAuth may handle permissions better
- Fixes 'could not open file for reading' and 'not a git repository' errors
@0xferit
Copy link
Member Author

0xferit commented Jul 14, 2025

@claude

Copy link

github-actions bot commented Jul 14, 2025

Claude encountered an error —— View job

Failed with exit code 128

I'll analyze this and get back to you.

cursor[bot]

This comment was marked as outdated.

- Add verification step to check if CLAUDE_CODE_OAUTH_TOKEN secret exists
- Workflow will fail early with clear message if secret is missing
- Helps debug authentication issues before Claude action runs
@0xferit
Copy link
Member Author

0xferit commented Jul 14, 2025

@claude test

Copy link

github-actions bot commented Jul 14, 2025

Claude encountered an error —— View job

Failed with exit code 128

I'll analyze this and get back to you.

cursor[bot]

This comment was marked as outdated.

- Explicitly set github_token to empty string to prevent fallback
- Add token length verification for debugging OAuth token
- Ensure action uses only OAuth token, not default GitHub token
- Should resolve authentication conflicts in action logs
Copy link

@0xferit
Copy link
Member Author

0xferit commented Jul 14, 2025

@claude test

Copy link

github-actions bot commented Jul 14, 2025

Claude encountered an error —— View job

Failed with exit code 128

I'll analyze this and get back to you.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Inconsistent Return Values in `getMetaEvidence`

The getMetaEvidence method implicitly returns undefined when no MetaEvidence events are found (events.length === 0). This is inconsistent with the catch block, which returns null on error, leading to callers receiving undefined instead of null for cases where meta evidence cannot be fetched.

src/app.js#L535-L567

dispute-resolver/src/app.js

Lines 535 to 567 in e1907fd

);
if (events.length > 0) {
const metaEvidenceURI = events[events.length - 1].args._evidence;
const response = await fetch(urlNormalize(metaEvidenceURI));
const rawMeta = await response.json();
const arbitratorChainID = rawMeta.arbitratorChainID || this.state.network;
const arbitrableChainID = rawMeta.arbitrableChainID || this.state.network;
console.log('Parsed chainIDs from raw meta:', { arbitratorChainID, arbitrableChainID });
const scriptParameters = {
disputeID: arbitratorDisputeID,
arbitrableContractAddress: arbitrableAddress,
arbitratorContractAddress: networkMap[this.state.network].KLEROS_LIQUID,
arbitratorChainID,
chainID: this.state.network,
arbitrableChainID,
arbitratorJsonRpcUrl: getReadOnlyRpcUrl({ chainId: arbitratorChainID }) ?? networkMap[this.state.network].WEB3_PROVIDER,
arbitrableJsonRpcUrl: getReadOnlyRpcUrl({ chainId: arbitrableChainID }) ?? networkMap[this.state.network].WEB3_PROVIDER,
};
const options = {
strict: true,
getJsonRpcUrl: chainId => getReadOnlyRpcUrl({ chainId }),
scriptParameters
};
return await this.state.archon.arbitrable.getMetaEvidence(
arbitrableAddress,
dispute.metaEvidenceID,
options
);
}
} catch (error) {
console.error('Error fetching meta evidence:', error);
return null;
}

Fix in CursorFix in Web


Was this report helpful? Give feedback by reacting with 👍 or 👎

@0xferit 0xferit marked this pull request as draft July 14, 2025 05:48
@0xferit 0xferit closed this Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant