Add graceful Redis failure handling with aggressive timeouts

- Wrap all Redis operations in try-catch blocks to prevent app crashes
- Add aggressive timeout configurations (200ms command, 500ms connect)
- Disable retries and offline queue for fast-fail behavior
- Remove unnecessary try-catch blocks from db.ts (now handled in RedisCache)
- App continues functioning without cache when Redis is unavailable

⚠️  UNTESTED - needs verification in staging environment

Author: bmcdorman

src/RedisCache.ts

@@ -9,31 +9,57 @@ class RedisCache implements Cache {
   private redis_: Redis;
 
   constructor(options: RedisOptions) {
-    this.redis_ = new Redis(options);
+    this.redis_ = new Redis({
+      ...options,
+      connectTimeout: 500,         // 500ms to connect
+      commandTimeout: 200,         // 200ms per command
+      retryStrategy: (times) => {
+        // Stop retrying after 2 attempts
+        if (times > 2) return null;
+        return 50; // Wait only 50ms between retries
+      },
+      maxRetriesPerRequest: 0,     // Don't retry - fail immediately
+      enableOfflineQueue: false,   // Don't queue commands when disconnected
+    });
+    
+    this.redis_.on('error', (err) => {
+      console.error('Redis error (app will continue without cache):', err.message);
+    });
   }
 
   private static key_ = ({ collection, id }: Selector): string => {
     return `${collection}/${id}`;
   };
 
   async get(selector: Selector): Promise<object | null> {
-    const data = await this.redis_.get(RedisCache.key_(selector));
-    if (!data) return null;
-
-    return JSON.parse(data);
+    try {
+      const data = await this.redis_.get(RedisCache.key_(selector));
+      if (!data) return null;
+      return JSON.parse(data);
+    } catch (err) {
+      console.error('Redis GET failed, continuing without cache:', err);
+      return null;
+    }
   }
 
   async set(selector: Selector, value: object | null): Promise<void> {
-    if (!value) {
-      await this.redis_.del(RedisCache.key_(selector));
-      return;
+    try {
+      if (!value) {
+        await this.redis_.del(RedisCache.key_(selector));
+        return;
+      }
+      await this.redis_.setex(RedisCache.key_(selector), RedisCache.DEFAULT_TTL, JSON.stringify(value));
+    } catch (err) {
+      console.error('Redis SET failed, continuing without cache:', err);
     }
-
-    await this.redis_.setex(RedisCache.key_(selector), RedisCache.DEFAULT_TTL, JSON.stringify(value));
   }
 
   async remove(selector: Selector): Promise<void> {
-    await this.redis_.del(RedisCache.key_(selector));
+    try {
+      await this.redis_.del(RedisCache.key_(selector));
+    } catch (err) {
+      console.error('Redis DEL failed, continuing without cache:', err);
+    }
   }
 }
 

src/db.ts

@@ -60,16 +60,12 @@ class Db {
 
     const cacheSelector: Selector = { ...selector, collection: fCollection };
 
-    try {
-      const cached = await this.cache_.get(cacheSelector);
+    const cached = await this.cache_.get(cacheSelector);
 
-      if (cached) return {
-        type: 'success',
-        value: cached as T,
-      };
-    } catch (e) {
-      console.error(e);
-    }
+    if (cached) return {
+      type: 'success',
+      value: cached as T,
+    };
 
     const doc = await firestore
       .collection(fCollection)
@@ -82,12 +78,8 @@ class Db {
       message: `Document "${selector.id}" not found.`,
     };
 
-    try {
-      // Update the cache
-      await this.cache_.set(cacheSelector, doc.data());
-    } catch (e) {
-      console.error(e);
-    }
+    // Update the cache
+    await this.cache_.set(cacheSelector, doc.data());
 
     return {
       type: 'success',
@@ -120,12 +112,7 @@ class Db {
       await docRef.set(value, { mergeFields: keysToReplace });
     } else {
       await docRef.set(value);
-
-      try {
-        await this.cache_.set(cacheSelector, value);
-      } catch (e) {
-        console.error(e);
-      }
+      await this.cache_.set(cacheSelector, value);
     }
 
     return {
@@ -143,11 +130,7 @@ class Db {
 
     const cacheSelector: Selector = { ...selector, collection: fCollection };
 
-    try {
-      await this.cache_.remove(cacheSelector);
-    } catch (e) {
-      console.error(e);
-    }
+    await this.cache_.remove(cacheSelector);
 
     await firestore
       .collection(fCollection)