Specify encoding to fix EncodingWarning in 3.10 #618
Closed
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the `EncodingWarning` that exists in Python 3.10 by specifying the encoding as UTF-8 for both the read and write methods for the filesystem persister ``` .../site-packages/vcr/persisters/filesystem.py:24: EncodingWarning: 'encoding' argument not specified with open(cassette_path, "w") as f: ```
Author
|
Test failure seems to be unrelated to my code: |
kevin1024
force-pushed
the
master
branch
3 times, most recently
from
df3997c to
34d5384
Compare
Owner
|
Closing this PR due to age and staleness. If this EncodingWarning is still present in the current codebase, please open a new issue or PR against the latest version. Thanks for the contribution! |
Author
|
As a language level warning this should still be caused with new Python versions unless an encoding was specified, but I’ll need to confirm that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the
EncodingWarningthat exists in Python 3.10 by specifying the encoding as UTF-8 for both the read and write methods for the filesystem persister