Skip to content

Commit 940d901

Browse files
committed
fix(tests): more of... replace realistic DB credentials in ibis table tests to avoid CI secret detection
Signed-off-by: gitgud5000 <[email protected]>
1 parent 0af5b82 commit 940d901

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

kedro-datasets/tests/ibis/test_table_dataset.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -382,24 +382,24 @@ def test_connection_config(self, mocker, table_dataset, connection_config, key):
382382
("credentials_config", "key"),
383383
[
384384
(
385-
"postgres://xxxxx:yyyyyy@xxxx.postgres.database.azure.com:5432/postgres",
385+
"postgres://xxxxxx.postgres.database.azure.com:5432/postgres",
386386
(
387387
("backend", "postgres"),
388388
(
389389
"con",
390-
"postgres://xxxxx:yyyyyy@xxxx.postgres.database.azure.com:5432/postgres",
390+
"postgres://xxxxxx.postgres.database.azure.com:5432/postgres",
391391
),
392392
),
393393
),
394394
(
395395
{
396-
"con": "postgres://xxxxx:yyyyyy@xxxx.postgres.database.azure.com:5432/postgres"
396+
"con": "postgres://xxxxxx@xxxx.postgres.database.azure.com:5432/postgres"
397397
},
398398
(
399399
("backend", "postgres"),
400400
(
401401
"con",
402-
"postgres://xxxxx:yyyyyy@xxxx.postgres.database.azure.com:5432/postgres",
402+
"postgres://xxxxxx@xxxx.postgres.database.azure.com:5432/postgres",
403403
),
404404
),
405405
),
@@ -455,7 +455,7 @@ def test_get_backend_name_dict_without_backend_or_con(self):
455455

456456
def test_get_backend_name_string_with_scheme(self):
457457
ds = TableDataset(table_name="t")
458-
ds._credentials = "mysql://uxxxxx:yyyyyy@host:3306/dbname"
458+
ds._credentials = "mysql://xxxxxx@host:3306/dbname"
459459
assert ds._get_backend_name() == "mysql"
460460

461461
def test_get_backend_name_string_without_scheme(self):
@@ -466,7 +466,7 @@ def test_get_backend_name_string_without_scheme(self):
466466
def test_get_backend_name_dict_with_con_and_scheme(self):
467467
ds = TableDataset(table_name="t")
468468
ds._credentials = {
469-
"con": "postgres://user:pass@host:5432/dbname",
469+
"con": "postgres://xxxxxx@host:5432/dbname",
470470
"some_other": "value",
471471
}
472472
assert ds._get_backend_name() == "postgres"

0 commit comments

Comments
 (0)