Skip to content

fix: skip workspace roles in MetadataFetcher to prevent migration failures #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
devin-ai-integration wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: skip workspace roles in MetadataFetcher to prevent migration failures #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/MetadataFetcher.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,9 @@ private function getOtherRolesToMainProjectRole(array $roles): array
$filteredRolesInRole = array_filter($rolesInRole, fn(GrantToRole $v) => !in_array($v->getName(), $roles));

foreach ($filteredRolesInRole as $item) {
if (Helper::isWorkspaceRole($item->getName())) {
continue;
}
$roles[$item->getName()] = Role::fromArray([
'name' => $item->getName(),
'owner' => $item->getGranteeName(),
Expand Down
13 changes: 13 additions & 0 deletions src/Snowflake/Helper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,19 @@ public static function filterUserDollarGrants(array $grants): array
});
}

/**
* Checks if a role name is a workspace role that should be skipped during migration.
* Workspace roles are ephemeral and dynamically created by Keboola when workspaces are provisioned.
* They may be deleted between migration phases, causing "Role does not exist" errors.
*
* @param string $roleName The role name to check
* @return bool True if the role is a workspace role that should be skipped
*/
public static function isWorkspaceRole(string $roleName): bool
{
return (bool) preg_match('/^(KEBOOLA|SAPI|sapi)_WORKSPACE_/', $roleName);
}

/**
* @param GrantToRole[] $grants
*/
Expand Down