fix: skip workspace roles in MetadataFetcher to prevent migration failures #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lures Workspace roles (KEBOOLA_WORKSPACE_*, SAPI_WORKSPACE_*) are ephemeral and dynamically created by Keboola when workspaces are provisioned. They may be deleted between migration phases, causing 'Role does not exist' errors when phase 2 (data migration) tries to fetch grants for roles that no longer exist. This change adds a helper method to identify workspace roles and filters them out in getOtherRolesToMainProjectRole() before attempting to query their grants. Co-Authored-By: David Pospisil <[email protected]>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes phase 2 (data migration) failures when workspace roles have been deleted between migration phases. Workspace roles (
KEBOOLA_WORKSPACE_*,SAPI_WORKSPACE_*) are ephemeral and dynamically created by Keboola when workspaces are provisioned. When they're deleted after phase 1 runs but before phase 2, theSHOW GRANTS TO ROLEquery fails with "Role does not exist or not authorized".This change:
Helper::isWorkspaceRole()to identify workspace role naming patternsgetOtherRolesToMainProjectRole()before attempting to query their grantsReview & Testing Checklist for Human
/^(KEBOOLA|SAPI|sapi)_WORKSPACE_/may not cover all workspace role naming conventions used across different Keboola environmentsMigrateData.phpto ensure no critical warehouse/ownership grants come exclusively from workspace rolesNotes
Link to Devin run: https://app.devin.ai/sessions/2058b7baed6d4a2b95b2fcfea863c243
Requested by: David Pospisil (@baullmear)