Skip to content

Commit 10488ed

Browse files
Soha-Albaghdadymaxmoehl
authored andcommitted
refactor: log the unregisteration of a route before the endpoint
1 parent 73aae51 commit 10488ed

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

src/code.cloudfoundry.org/gorouter/registry/registry.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -184,13 +184,6 @@ func (r *RouteRegistry) Unregister(uri route.Uri, endpoint *route.Endpoint) {
184184

185185
r.reporter.CaptureUnregistryMessage(endpoint)
186186

187-
if routeRemoved {
188-
r.logger.Info("route-unregistered", slog.Any("uri", uri))
189-
r.reporter.CaptureRoutesUnregistered()
190-
} else {
191-
r.logger.Info("route-not-unregistered", slog.Any("uri", uri))
192-
}
193-
194187
var logMsg string
195188
if endpointRemoved {
196189
logMsg = "endpoint-unregistered"
@@ -201,6 +194,13 @@ func (r *RouteRegistry) Unregister(uri route.Uri, endpoint *route.Endpoint) {
201194
if r.logger.Enabled(context.Background(), slog.LevelInfo) {
202195
r.logger.Info(logMsg, buildSlogAttrs(uri, endpoint)...)
203196
}
197+
198+
if routeRemoved {
199+
r.logger.Info("route-unregistered", slog.Any("uri", uri))
200+
r.reporter.CaptureRoutesUnregistered()
201+
} else {
202+
r.logger.Info("route-not-unregistered", slog.Any("uri", uri))
203+
}
204204
}
205205

206206
func (r *RouteRegistry) unregister(uri route.Uri, endpoint *route.Endpoint) (endpointRemoved, routeRemoved bool) {

0 commit comments

Comments
 (0)