Difficulties to edit, update claims of Q1841

[hugolpz]

I work on Q1841, you may test on Q1842 if wanted.

My modifications success goes as follow :

• success by update: description.en by redefining the value (=update)
• success by remove + create/add : P4 language
• fails to update or create: P3 recording URL pointer (P3)

I did not find clean answer in the readme.md nor .data() documentation

P3 is of type commonMedia, see P3, which may affect the update ?

Documentation improvements

Generally speaking, documentation for .modify() (missing from doc?), .new_data_entity(), .data(), modify_data_entity need improvement to be clearer. (If I understand those functions I will then edit those documentations).

Documentation of .data shows both READ and UPDATE, which is actually WRITE or DELETE behaviors.
.data should focus on READ behavior, may be split into .data (READ) and .modify (WRITE, DELETE, UPDATE).

Code sample are miss-labelled : .data's "update" actually .modify by ADDING a value (WRITE), and does not update existing claim.

As of now, from the doc, I don't see how to UPDATE claims (but I may have missed it !)

Code for Q1841's .modify()

      title = 'Q1841';
      let entity = await wiki.data(title);
      // Update P3 `url`
      let P3 = await wiki.data(title, 'P3');  // returns array of values
      // No code sample in documentation on how to UPDATE claims
      // Remove:
      await entity.modify({ claims: [{ P3: P3[0], remove: true }] }, { bot: 1, reason: 'remove before correction' }); // works : remove property
      // Create:
      await entity.modify({ claims: [{ P3: "Hola!" }] }, { bot: 1, reason: 'correction' }); // fails: doesnt add property P3 + value.

Initial P3

"P3": [
  {
    "mainsnak": {
      "snaktype": "value",
      "property": "P3",
      "hash": "f5f7e5a50c8157de0092ec4bcb47cfe475b67900",
      "datavalue": {
        "value": "LL-Q7850 (zho)-Wang Cheng (Yug)-谁.wav",
        "type": "string"
      },
      "datatype": "commonsMedia"
    },
    "type": "statement",
    "id": "Q1841$E46884DD-1A6A-48CA-8B23-7B3F26BA2D41",
    "rank": "normal"
  }
],

.data(entity)

{
  "pageid": 3222,
  "ns": 0,
  "title": "Q1841",
  "lastrevid": 785239,
  "modified": "2022-08-22T07:35:12Z",
  "type": "item",
  "id": "Q1841",
  "labels": {
    "en": {
      "language": "en",
      "value": "谁"
    }
  },
  "descriptions": {
    "en": {
      "language": "en",
      "value": "audio record - cmn - Wang Cheng (Yug)"
    }
  },
  "aliases": {},
  "claims": {
    "P2": [
      {
        "mainsnak": {
          "snaktype": "value",
          "property": "P2",
          "hash": "6511c2931be27bcac018d16006b07c7c2e704c57",
          "datavalue": {
            "value": {
              "entity-type": "item",
              "numeric-id": 2,
              "id": "Q2"
            },
            "type": "wikibase-entityid"
          },
          "datatype": "wikibase-item"
        },
        "type": "statement",
        "id": "Q1841$2A241AA7-B149-4E11-A9F6-BA5ED700472D",
        "rank": "normal"
      }
    ],
    "P3": [
      {
        "mainsnak": {
          "snaktype": "value",
          "property": "P3",
          "hash": "f5f7e5a50c8157de0092ec4bcb47cfe475b67900",
          "datavalue": {
            "value": "LL-Q7850 (zho)-Wang Cheng (Yug)-谁.wav",
            "type": "string"
          },
          "datatype": "commonsMedia"
        },
        "type": "statement",
        "id": "Q1841$E46884DD-1A6A-48CA-8B23-7B3F26BA2D41",
        "rank": "normal"
      }
    ],
    "P9": [
      {
        "mainsnak": {
          "snaktype": "value",
          "property": "P9",
          "hash": "0edb2831a379eec7c9bed1be6ea9d8c3025b30ad",
          "datavalue": {
            "value": {
              "entity-type": "item",
              "numeric-id": 8,
              "id": "Q8"
            },
            "type": "wikibase-entityid"
          },
          "datatype": "wikibase-item"
        },
        "type": "statement",
        "id": "Q1841$05158ACD-DA18-4AFC-992A-1D485843C694",
        "rank": "normal"
      }
    ],
    "P4": [
      {
        "mainsnak": {
          "snaktype": "value",
          "property": "P4",
          "hash": "bbc4b3c1ca034874a5ac02c1e1b2c93beeb2bfa4",
          "datavalue": {
            "value": {
              "entity-type": "item",
              "numeric-id": 113,
              "id": "Q113"
            },
            "type": "wikibase-entityid"
          },
          "datatype": "wikibase-item"
        },
        "type": "statement",
        "id": "Q1841$86D4932C-AB58-4767-8A13-874134575AF2",
        "rank": "normal"
      }
    ],
    "P5": [
      {
        "mainsnak": {
          "snaktype": "value",
          "property": "P5",
          "hash": "7ada144b750e5d350a3b160a1b1f3f18ea3acb9e",
          "datavalue": {
            "value": {
              "entity-type": "item",
              "numeric-id": 1832,
              "id": "Q1832"
            },
            "type": "wikibase-entityid"
          },
          "datatype": "wikibase-item"
        },
        "type": "statement",
        "id": "Q1841$899507C2-E271-4B57-80FC-3F5BC34C71D9",
        "rank": "normal"
      }
    ],
    "P6": [
      {
        "mainsnak": {
          "snaktype": "value",
          "property": "P6",
          "hash": "72b1254e9e7d7e86e7a84275d535fe6757a3f9fd",
          "datavalue": {
            "value": {
              "time": "+2018-06-02T00:00:00Z",
              "timezone": 0,
              "before": 0,
              "after": 0,
              "precision": 11,
              "calendarmodel": "http://www.wikidata.org/entity/Q1985727"
            },
            "type": "time"
          },
          "datatype": "time"
        },
        "type": "statement",
        "id": "Q1841$AFD04305-5A2E-454C-9135-19C4E8B507BC",
        "rank": "normal"
      }
    ],
    "P7": [
      {
        "mainsnak": {
          "snaktype": "value",
          "property": "P7",
          "hash": "12dab18626f811d6e0b3289e6b391af58b0fd5d8",
          "datavalue": {
            "value": "谁",
            "type": "string"
          },
          "datatype": "string"
        },
        "type": "statement",
        "id": "Q1841$DA38C0FA-67C3-4F2F-9F50-CEA0072BB7DC",
        "rank": "normal"
      }
    ]
  },
  "sitelinks": {}
}```

[kanasimi]

I have updated the document.
Please note: You must update to the latest code and add a language : 'en' attribute.

I use this:

entity = await wiki.data('Q1841');
await entity.modify({ claims: [{ P3: "LL-Q7850 (zho)-Wang Cheng (Yug)-谁.wav", remove: true }] }, { bot: 1, summary: 'test edit: Remove specific value' });

entity = await wiki.data('Q1841');
await entity.modify({ claims: [{ P3: "LL-Q7850 (zho)-Wang Cheng (Yug)-谁.wav" }] }, { bot: 1, summary: 'test edit: add' });

[hugolpz]

Some error in my code but cannot do it now.