Fix nvm loading issue.

We should not rely on success exit status from nvm.sh loading.

Fixes moodlehq#309

Author: kabalin

docs/CHANGELOG.md

@@ -9,6 +9,8 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 The format of this change log follows the advice given at [Keep a CHANGELOG](http://keepachangelog.com).
 
 ## [Unreleased]
+### Changed
+- Fixed nvm loading issue caused by upstream regression.
 
 ## [3.4.13] - 2023-09-02
 ### Changed

src/Installer/VendorInstaller.php

@@ -129,7 +129,7 @@ public function installNode()
         }
 
         $nvmDir  = getenv('NVM_DIR');
-        $cmd     = ". $nvmDir/nvm.sh && nvm install && nvm use && echo \"NVM_BIN=\$NVM_BIN\"";
+        $cmd     = ". $nvmDir/nvm.sh; nvm install && nvm use && echo \"NVM_BIN=\$NVM_BIN\"";
         $process = $this->execute->passThrough($cmd, $this->moodle->directory);
         if (!$process->isSuccessful()) {
             throw new \RuntimeException('Node.js installation failed.');